Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tagging @mtmorgan as per our previous discussions on Slack.
Typical usage:
A couple of points:
set_omp_threads()
(stolen from ShortRead) to control the number of OpenMP threads globally. This would be an excellent candidate for inclusion as an option in aBiocParallelParam
object somewhere, such that entry into abp*apply
loop also sets the OpenMP threads. This would centralize control of OpenMP parallelization into the BiocParallel framework, and free developers from having to define their own OpenMP-related arguments in every parallelized functions.