AccountBalanceChangeEvent #2

Clem-Fern · 2024-12-08T19:42:15Z

Lands integration

Dev

src/main/java/org/gestern/gringotts/event/AccountListener.java

GroobleDierne

j'ai mis un commentaire, le reste a l'air good

src/main/java/org/gestern/gringotts/event/AccountListener.java

…()" because "holder" is null

Clem-Fern

746eb0e Fix pour l'erreur ci-dessous lors de la destruction d'un vault coffre simple:

[23:17:05 ERROR]: Could not pass event BlockDestroyEvent to Gringotts v3.0.1-SNAPSHOT
java.lang.NullPointerException: Cannot invoke "org.bukkit.inventory.InventoryHolder.getInventory()" because "holder" is null
        at gringotts-3.0.1-SNAPSHOT.jar/org.gestern.gringotts.AccountChest.matchesLocation(AccountChest.java:102) ~[gringotts-3.0.1-SNAPSHOT.jar:?]
        at gringotts-3.0.1-SNAPSHOT.jar/org.gestern.gringotts.event.AccountListener.getAccountChestFromLocation(AccountListener.java:195) ~[gringotts-3.0.1-SNAPSHOT.jar:?]
        at gringotts-3.0.1-SNAPSHOT.jar/org.gestern.gringotts.event.AccountListener.onSignBreak(AccountListener.java:90) ~[gringotts-3.0.1-SNAPSHOT.jar:?]
        at com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor14.execute(Unknown Source) ~[?:?]
        at org.bukkit.plugin.EventExecutor$2.execute(EventExecutor.java:77) ~[paper-mojangapi-1.21.1-R0.1-SNAPSHOT.jar:?]
        at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:80) ~[paper-mojangapi-1.21.1-R0.1-SNAPSHOT.jar:1.21.1-131-84281ce]
        at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70) ~[paper-mojangapi-1.21.1-R0.1-SNAPSHOT.jar:?]
        at io.papermc.paper.plugin.manager.PaperEventManager.callEvent(PaperEventManager.java:54) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.callEvent(PaperPluginManagerImpl.java:131) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:628) ~[paper-mojangapi-1.21.1-R0.1-SNAPSHOT.jar:?]
        at org.bukkit.event.Event.callEvent(Event.java:45) ~[paper-mojangapi-1.21.1-R0.1-SNAPSHOT.jar:?]
        at net.minecraft.world.level.Level.destroyBlock(Level.java:1186) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.world.level.block.Block.updateOrDestroy(Block.java:200) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.world.level.redstone.NeighborUpdater.executeShapeUpdate(NeighborUpdater.java:50) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.world.level.redstone.CollectingNeighborUpdater$ShapeUpdate.runNext(CollectingNeighborUpdater.java:152) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.world.level.redstone.CollectingNeighborUpdater.runUpdates(CollectingNeighborUpdater.java:80) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.world.level.redstone.CollectingNeighborUpdater.addAndRun(CollectingNeighborUpdater.java:65) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.world.level.redstone.CollectingNeighborUpdater.shapeUpdate(CollectingNeighborUpdater.java:30) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.world.level.Level.neighborShapeChanged(Level.java:1237) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.world.level.block.state.BlockBehaviour$BlockStateBase.updateNeighbourShapes(BlockBehaviour.java:1190) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.world.level.Level.notifyAndUpdatePhysics(Level.java:1147) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.world.level.Level.setBlock(Level.java:1098) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.world.level.Level.setBlock(Level.java:1012) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.world.level.Level.removeBlock(Level.java:1167) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.server.level.ServerPlayerGameMode.destroyBlock(ServerPlayerGameMode.java:430) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.server.level.ServerPlayerGameMode.destroyAndAck(ServerPlayerGameMode.java:342) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.server.level.ServerPlayerGameMode.handleBlockBreakAction(ServerPlayerGameMode.java:215) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.server.network.ServerGamePacketListenerImpl.handlePlayerAction(ServerGamePacketListenerImpl.java:1856) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.network.protocol.game.ServerboundPlayerActionPacket.handle(ServerboundPlayerActionPacket.java:51) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.network.protocol.game.ServerboundPlayerActionPacket.handle(ServerboundPlayerActionPacket.java:20) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.network.protocol.PacketUtils.lambda$ensureRunningOnSameThread$0(PacketUtils.java:56) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.server.TickTask.run(TickTask.java:18) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.util.thread.BlockableEventLoop.doRunTask(BlockableEventLoop.java:151) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.util.thread.ReentrantBlockableEventLoop.doRunTask(ReentrantBlockableEventLoop.java:24) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.server.MinecraftServer.doRunTask(MinecraftServer.java:1535) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.server.MinecraftServer.doRunTask(MinecraftServer.java:201) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.util.thread.BlockableEventLoop.pollTask(BlockableEventLoop.java:125) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.server.MinecraftServer.pollTaskInternal(MinecraftServer.java:1512) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.server.MinecraftServer.pollTask(MinecraftServer.java:1505) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.util.thread.BlockableEventLoop.managedBlock(BlockableEventLoop.java:135) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.server.MinecraftServer.managedBlock(MinecraftServer.java:1464) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.server.MinecraftServer.waitUntilNextTick(MinecraftServer.java:1471) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1316) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:329) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at java.base/java.lang.Thread.run(Thread.java:1583) ~[?:?]

…ntory()" because "holder" is null

Clem-Fern · 2024-12-19T22:59:28Z

34e57a1 Fix l'erreur ci-dessous à l'intéraction avec un coffre après avoir cassé un panneau de vault.

[23:57:06 ERROR]: Could not pass event InventoryCloseEvent to Gringotts v3.0.1-SNAPSHOT
java.lang.NullPointerException: Cannot invoke "org.bukkit.inventory.InventoryHolder.getInventory()" because "holder" is null
        at gringotts-3.0.1-SNAPSHOT.jar/org.gestern.gringotts.AccountChest.matchesLocation(AccountChest.java:102) ~[gringotts-3.0.1-SNAPSHOT.jar:?]
        at gringotts-3.0.1-SNAPSHOT.jar/org.gestern.gringotts.event.AccountListener.getAccountChestFromHolder(AccountListener.java:170) ~[gringotts-3.0.1-SNAPSHOT.jar:?]
        at gringotts-3.0.1-SNAPSHOT.jar/org.gestern.gringotts.event.AccountListener.onInventoryClose(AccountListener.java:99) ~[gringotts-3.0.1-SNAPSHOT.jar:?]
        at com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor5.execute(Unknown Source) ~[?:?]
        at org.bukkit.plugin.EventExecutor$2.execute(EventExecutor.java:77) ~[paper-mojangapi-1.21.1-R0.1-SNAPSHOT.jar:?]
        at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:80) ~[paper-mojangapi-1.21.1-R0.1-SNAPSHOT.jar:1.21.1-131-84281ce]
        at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70) ~[paper-mojangapi-1.21.1-R0.1-SNAPSHOT.jar:?]
        at io.papermc.paper.plugin.manager.PaperEventManager.callEvent(PaperEventManager.java:54) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.callEvent(PaperPluginManagerImpl.java:131) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:628) ~[paper-mojangapi-1.21.1-R0.1-SNAPSHOT.jar:?]
        at org.bukkit.craftbukkit.event.CraftEventFactory.handleInventoryCloseEvent(CraftEventFactory.java:1646) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.server.network.ServerGamePacketListenerImpl.handleContainerClose(ServerGamePacketListenerImpl.java:2957) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.server.network.ServerGamePacketListenerImpl.handleContainerClose(ServerGamePacketListenerImpl.java:2950) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.network.protocol.game.ServerboundContainerClosePacket.handle(ServerboundContainerClosePacket.java:33) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.network.protocol.game.ServerboundContainerClosePacket.handle(ServerboundContainerClosePacket.java:15) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.network.protocol.PacketUtils.lambda$ensureRunningOnSameThread$0(PacketUtils.java:56) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.server.TickTask.run(TickTask.java:18) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.util.thread.BlockableEventLoop.doRunTask(BlockableEventLoop.java:151) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.util.thread.ReentrantBlockableEventLoop.doRunTask(ReentrantBlockableEventLoop.java:24) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.server.MinecraftServer.doRunTask(MinecraftServer.java:1535) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.server.MinecraftServer.doRunTask(MinecraftServer.java:201) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.util.thread.BlockableEventLoop.pollTask(BlockableEventLoop.java:125) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.server.MinecraftServer.pollTaskInternal(MinecraftServer.java:1512) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.server.MinecraftServer.pollTask(MinecraftServer.java:1505) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.util.thread.BlockableEventLoop.managedBlock(BlockableEventLoop.java:135) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.server.MinecraftServer.managedBlock(MinecraftServer.java:1464) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.server.MinecraftServer.waitUntilNextTick(MinecraftServer.java:1471) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1316) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:329) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at java.base/java.lang.Thread.run(Thread.java:1583) ~[?:?]
 ```

…nventory()" because "holder" is null" This reverts commit 746eb0e.

… "chest" is null

Clem-Fern · 2024-12-22T14:45:43Z

288e0b8 Fix l'erreur ci-dessous à la destruction d'un panneau.

[15:37:09 ERROR]: Could not pass event BlockBreakEvent to Gringotts v3.0.1-SNAPSHOT
java.lang.NullPointerException: Cannot read field "sign" because "chest" is null
        at gringotts-3.0.1-SNAPSHOT.jar/org.gestern.gringotts.data.EBeanDAO.deleteAccountChest(EBeanDAO.java:88) ~[gringotts-3.0.1-SNAPSHOT.jar:?]
        at gringotts-3.0.1-SNAPSHOT.jar/org.gestern.gringotts.event.AccountListener.onSignBreak(AccountListener.java:105) ~[gringotts-3.0.1-SNAPSHOT.jar:?]
        at gringotts-3.0.1-SNAPSHOT.jar/org.gestern.gringotts.event.AccountListener.onSignBreak(AccountListener.java:99) ~[gringotts-3.0.1-SNAPSHOT.jar:?]
        at com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor13.execute(Unknown Source) ~[?:?]
        at org.bukkit.plugin.EventExecutor$2.execute(EventExecutor.java:77) ~[paper-mojangapi-1.21.1-R0.1-SNAPSHOT.jar:?]
        at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:80) ~[paper-mojangapi-1.21.1-R0.1-SNAPSHOT.jar:1.21.1-131-84281ce]
        at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70) ~[paper-mojangapi-1.21.1-R0.1-SNAPSHOT.jar:?]
        at io.papermc.paper.plugin.manager.PaperEventManager.callEvent(PaperEventManager.java:54) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.callEvent(PaperPluginManagerImpl.java:131) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:628) ~[paper-mojangapi-1.21.1-R0.1-SNAPSHOT.jar:?]
        at net.minecraft.server.level.ServerPlayerGameMode.destroyBlock(ServerPlayerGameMode.java:383) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.server.level.ServerPlayerGameMode.destroyAndAck(ServerPlayerGameMode.java:342) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.server.level.ServerPlayerGameMode.handleBlockBreakAction(ServerPlayerGameMode.java:215) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.server.network.ServerGamePacketListenerImpl.handlePlayerAction(ServerGamePacketListenerImpl.java:1856) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.network.protocol.game.ServerboundPlayerActionPacket.handle(ServerboundPlayerActionPacket.java:51) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.network.protocol.game.ServerboundPlayerActionPacket.handle(ServerboundPlayerActionPacket.java:20) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.network.protocol.PacketUtils.lambda$ensureRunningOnSameThread$0(PacketUtils.java:56) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.server.TickTask.run(TickTask.java:18) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.util.thread.BlockableEventLoop.doRunTask(BlockableEventLoop.java:151) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.util.thread.ReentrantBlockableEventLoop.doRunTask(ReentrantBlockableEventLoop.java:24) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.server.MinecraftServer.doRunTask(MinecraftServer.java:1535) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.server.MinecraftServer.doRunTask(MinecraftServer.java:201) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.util.thread.BlockableEventLoop.pollTask(BlockableEventLoop.java:125) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.server.MinecraftServer.pollTaskInternal(MinecraftServer.java:1512) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.server.MinecraftServer.pollTask(MinecraftServer.java:1505) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.util.thread.BlockableEventLoop.managedBlock(BlockableEventLoop.java:135) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.server.MinecraftServer.managedBlock(MinecraftServer.java:1464) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.server.MinecraftServer.waitUntilNextTick(MinecraftServer.java:1471) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1316) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:329) ~[paper-1.21.1.jar:1.21.1-131-84281ce]
        at java.base/java.lang.Thread.run(Thread.java:1583) ~[?:?]

…royed

Clem-Fern and others added 4 commits November 29, 2024 18:47

wip: AccountBalanceChangeEvent

45fe2df

wip: AccountBalanceChangeEvent - implement toString

47f8116

Merge pull request #1 from Clem-Fern/dev

f361f1c

Dev

wip: AccountBalanceChangeEvent - fire event only if update happens

efd6903

Clem-Fern mentioned this pull request Dec 8, 2024

Dev LaBoulangerie/gringotts-lands#1

Open

Clem-Fern commented Dec 8, 2024

View reviewed changes

src/main/java/org/gestern/gringotts/event/AccountListener.java Outdated Show resolved Hide resolved

clean up debug

88d7ab1

GroobleDierne reviewed Dec 10, 2024

View reviewed changes

src/main/java/org/gestern/gringotts/event/AccountListener.java Outdated Show resolved Hide resolved

Clem-Fern added 2 commits December 16, 2024 23:51

wip: AccountBalanceChangeEvent - fire event on account chest deletion

dfd3f89

fix onSignBreak NullPointerException on "InventoryHolder.getInventory…

746eb0e

…()" because "holder" is null

Clem-Fern commented Dec 19, 2024

View reviewed changes

fix onInventoryClose NullPointerException on "InventoryHolder.getInve…

34e57a1

…ntory()" because "holder" is null

Clem-Fern requested a review from GroobleDierne December 19, 2024 23:00

GroobleDierne and others added 4 commits December 22, 2024 13:12

Revert "fix onSignBreak NullPointerException on "InventoryHolder.getI…

8f2c4f9

…nventory()" because "holder" is null" This reverts commit 746eb0e.

Fix getAccountChestFromLocation

eef1b1f

Perf and readability improvement

75dab39

fix onSignBreak NullPointerException Cannot read field "sign" because…

288e0b8

… "chest" is null

Clem-Fern added 2 commits December 22, 2024 15:52

fire AccountBalanceChangeEvent on vault creation when chest not empty

63ee513

fire AccountBalanceChangeEvent when one of double chest vault is dest…

5a68a0c

…royed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AccountBalanceChangeEvent #2

AccountBalanceChangeEvent #2

Clem-Fern commented Dec 8, 2024

GroobleDierne left a comment

Clem-Fern left a comment •

edited

Loading

Clem-Fern commented Dec 19, 2024

Clem-Fern commented Dec 22, 2024

AccountBalanceChangeEvent #2

Are you sure you want to change the base?

AccountBalanceChangeEvent #2

Conversation

Clem-Fern commented Dec 8, 2024

GroobleDierne left a comment

Choose a reason for hiding this comment

Clem-Fern left a comment • edited Loading

Choose a reason for hiding this comment

Clem-Fern commented Dec 19, 2024

Clem-Fern commented Dec 22, 2024

Clem-Fern left a comment •

edited

Loading