Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use standard formatting to cleanup source code. use eslint #30

Merged
merged 22 commits into from
Aug 8, 2024
Merged

Use standard formatting to cleanup source code. use eslint #30

merged 22 commits into from
Aug 8, 2024

Conversation

hcientist
Copy link
Member

huge thanks to contributors @mfwolffe and @purejerome

hcientist and others added 21 commits August 7, 2024 22:58
@hcientist
@purejerome says to put this in eslint
1b835ad
@hcientist
let's configure the project to use the eslint for the formatter and t…
bfe6e48 
…o format all the time. thanks @purejerome
@hcientist
update prettier version, require eslint plugin
b579475
@hcientist
@purejerome says to put this in eslint
9e8cace
@hcientist
update prettier version, require eslint plugin
0a2a16f
@hcientist
test standardizing format on a single file: api.js
f4aad36 
tested with
npx eslint --config .eslintrc.json api.js

seems like I only needed to do

npx eslint api.js
@hcientist
eslint and prettier disagree about indentation, let prettier win bc w…
f9fd4af 
…ho cares
@hcientist
with these changes, top-level .js files all pass eslint with no warni…
3b0d868 
…ngs or errors
@hcientist
with these changes, top-level pages pass linter
007faf1
@hcientist
whoops this extension cannot format jsx.
f463c24
@hcientist
with these changes, all pages pass linter
9f80e97
@hcientist
don't care about this rule
b288e59
@hcientist
most files are formatted. many linting errors remain, i'm inclined to…
7de6211 
… fix most of them...
@mfwolffe @hcientist
fix eslint problems in variations.js
18d9eb2
@mfwolffe @hcientist
flatjs and performjs eslint
66bc42b
@mfwolffe @hcientist
recentSubmissionjs; verify camelcase rename does not break
2d1ed11
@mfwolffe @hcientist
piece picker - switch to useCallback() to satisfy linter
2baab2c
@mfwolffe @hcientist
imports out of order
da91e9a
@mfwolffe @hcientist
theoreticaljs eslint; preferred approach for array indices in div keys?
f564d04
@mfwolffe @hcientist
exploratoryjs linter; mostly useCallbacks
c55038a
@hcientist
dropped nested ternary since it was overcomplicated anyway, these are…
c8a3042 
… now inteneded to be mutually exclusive, but we drop the guarantee, risk is acceptable.
hcientist
hcientist commented Aug 8, 2024
View reviewed changes
Copy link
Member Author

@hcientist hcientist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it! 🚀

@hcientist hcientist merged commit c95abea into Lab-Lab-Lab:main Aug 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hcientist @mfwolffe