Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add files via upload #584

Merged
merged 4 commits into from
Jul 24, 2023
Merged

Add files via upload #584

merged 4 commits into from
Jul 24, 2023

Conversation

r9x
Copy link
Contributor

@r9x r9x commented Jun 27, 2023

Type of change

  • Add new directory for a server
  • Update directory of a server
  • Documentation Update

Checklist

  • I have read the README doc
  • I have compressed the images appropriately (e.g. on https://tinypng.com)
  • I have created the manifest.json with the required values

Further comments

@github-actions
Copy link

Just as an information:
Your server VeinMC.com could be offline.
In general, we only accept

Copy link
Member

@JakobBruening JakobBruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please compress images

@r9x
Copy link
Contributor Author

r9x commented Jul 5, 2023

Please compress images

done

@scrummer
Copy link
Member

@r9x With your image-compressing update you deleted your whole folder including the manifest.json which is mandatory. Please create it again.

And another thing: Although it is not a requirement, please rename your folder to all lowercase VeinMC -> veinmc to match the convention from all other servers. Make sure to adapt this change to your manifest.json

@github-actions
Copy link

Just as an information:
Your server VeinMC.com could be offline.
In general, we only accept pull requests from servers, that are online. Please change this, otherwise we cannot review your server correctly and have to deny the pull request.

If your server is currently online, then our api returned a wrong status, we will have a look at it :)

Reference: API URL (https://api.mcsrvstat.us/2/VeinMC.com)

@r9x
Copy link
Contributor Author

r9x commented Jul 22, 2023

@scrummer

@JakobBruening JakobBruening merged commit 1ac1795 into LabyMod:master Jul 24, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants