Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LazerLife #594

Merged
merged 13 commits into from
Jul 12, 2023
Merged

Add LazerLife #594

merged 13 commits into from
Jul 12, 2023

Conversation

Mik6060
Copy link
Contributor

@Mik6060 Mik6060 commented Jul 7, 2023

Type of change

  • Add new directory for a server
  • Update directory of a server
  • Documentation Update

Checklist

  • I have read the README doc
  • I have compressed the images appropriately (e.g. on https://tinypng.com)
  • I have created the manifest.json with the required values

Further comments

@Mik6060 Mik6060 changed the title LazerLife Add LazerLife Jul 10, 2023
@scrummer
Copy link
Member

Hi @Mik6060
Can you please check your server? I was not able to connect to it neither with 1.8 nor with 1.19.

We can only accept servers which are up and running and available for publicity

Best,
Scrummer

@Mik6060
Copy link
Contributor Author

Mik6060 commented Jul 12, 2023

Hello @scrummer
Everything should work now, the server is running on version 1.19.2 or higher

@scrummer
Copy link
Member

@Mik6060 Still not able to connect:
image

could not connect to a default or fallback server. incorrectly configured address/port/firewall? io.netty.channel.AbstractChannel$AnnotatedConnectException

Seems to be a server-side problem from googling it quickly...

@Mik6060
Copy link
Contributor Author

Mik6060 commented Jul 12, 2023

Which version are you trying to connect to?

@Mik6060
Copy link
Contributor Author

Mik6060 commented Jul 12, 2023

Hello @scrummer
It should actually work now it may be that where you tried to connect I just did something on the server but now it has to work. With version 1.19.2 or higher. I have no problems connecting and neither does my second account.

Copy link
Member

@scrummer scrummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it works and I can connect.
One more small thing (sorry, did not see that in the first review): Please compress your images. They're too large.

~Scrummer

@Mik6060
Copy link
Contributor Author

Mik6060 commented Jul 12, 2023

ok i did it

@Mik6060 Mik6060 requested a review from scrummer July 12, 2023 14:10
@scrummer scrummer merged commit e17dda5 into LabyMod:master Jul 12, 2023
2 checks passed
@scrummer
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants