Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GommeHD #605

Merged
merged 3 commits into from
Jul 12, 2023
Merged

Update GommeHD #605

merged 3 commits into from
Jul 12, 2023

Conversation

TrainmasterHD
Copy link
Contributor

Type of change

  • Add new directory for a server
  • Update directory of a server
  • Documentation Update

Checklist

  • I have read the README doc
  • I have compressed the images appropriately (e.g. on https://tinypng.com)
  • I have created the manifest.json with the required values

Further comments

@scrummer
Copy link
Member

Hi @TrainmasterHD

Thank you very much!
One small thing: The supported_languages seem to be wrong. Those are languages that the server(!) supports (not website or whatever else).
On GommeHD there are only 23 valid languages (see screenshot) and you added 31 in the manifest? Please have a look at that.
image

Best,
Scrummer

@TrainmasterHD
Copy link
Contributor Author

Hi @scrummer,

thanks for your Feedback.

I've updated the supported_languages to match now the actively supported locales on the network.
Now there are fewer because we support some languages in multiple countries for example de_AT, de_CH, ...

@scrummer scrummer merged commit 6f1ce89 into LabyMod:master Jul 12, 2023
2 checks passed
@scrummer
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants