Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Kanmuru.NET #695

Closed
wants to merge 2 commits into from
Closed

Added Kanmuru.NET #695

wants to merge 2 commits into from

Conversation

xRxphael
Copy link
Contributor

Type of change

  • [*] Add new directory for a server
  • Update directory of a server
  • Documentation Update

Checklist

  • [*] I have read the README doc
  • [*] I have compressed the images appropriately (e.g. on https://tinypng.com)
  • [*] I have created the manifest.json with the required values

Further comments

@github-actions
Copy link

Just as an information:
Your server kanmuru.net could be offline.
In general, we only accept pull requests from servers, that are online. Please change this, otherwise we cannot review your server correctly and have to deny the pull request.

If your server is currently online, then our api returned a wrong status, we will have a look at it :)

Reference: API URL (https://api.mcsrvstat.us/2/kanmuru.net)

JakobBruening
JakobBruening requested changes Sep 19, 2023
View reviewed changes
minecraft_servers/kanmuru/manifest.json
"en"
],
"social": {
"web": "https://kanmuru.net",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bildschirmfoto 2023-09-19 um 19 21 33

minecraft_servers/kanmuru/manifest.json Outdated
},
"discord": {
"server_id": 826000371407257616,
"rename_to_minecraft_name": true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use false, as this is the default value and enabling is only allowed for partners.

@github-actions
Copy link

Just as an information:
Your server kanmuru.net could be offline.
In general, we only accept pull requests from servers, that are online. Please change this, otherwise we cannot review your server correctly and have to deny the pull request.

If your server is currently online, then our api returned a wrong status, we will have a look at it :)

Reference: API URL (https://api.mcsrvstat.us/2/kanmuru.net)

@JakobBruening JakobBruening reopened this Sep 30, 2023
@JakobBruening
Copy link
Member

Website still offline. Fix and then re-open again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakobBruening JakobBruening JakobBruening requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xRxphael @JakobBruening