LibWeb: Set the correct prototype for SVGAElement instances

LadybirdBrowser · Jun 28, 2024 · 4db05ec · 4db05ec
1 parent a84261e
commit 4db05ec
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 2 deletions.
diff --git a/Tests/LibWeb/Text/expected/SVG/a-element-prototype.txt b/Tests/LibWeb/Text/expected/SVG/a-element-prototype.txt
@@ -0,0 +1 @@
+true
diff --git a/Tests/LibWeb/Text/input/SVG/a-element-prototype.html b/Tests/LibWeb/Text/input/SVG/a-element-prototype.html
@@ -0,0 +1,7 @@
+<script src="../include.js"></script>
+<script>
+    test(() => {
+        let a = document.createElementNS("http://www.w3.org/2000/svg", "a");
+        println(a.__proto__ === SVGAElement.prototype);
+    });
+</script>
diff --git a/Userland/Libraries/LibWeb/SVG/SVGAElement.cpp b/Userland/Libraries/LibWeb/SVG/SVGAElement.cpp
@@ -4,6 +4,7 @@
  * SPDX-License-Identifier: BSD-2-Clause
  */
 
+#include <LibWeb/Bindings/SVGAElementPrototype.h>
 #include <LibWeb/Layout/SVGGraphicsBox.h>
 #include <LibWeb/SVG/SVGAElement.h>
 
@@ -18,6 +19,12 @@ SVGAElement::SVGAElement(DOM::Document& document, DOM::QualifiedName qualified_n
 
 SVGAElement::~SVGAElement() = default;
 
+void SVGAElement::initialize(JS::Realm& realm)
+{
+    Base::initialize(realm);
+    WEB_SET_PROTOTYPE_FOR_INTERFACE(SVGAElement);
+}
+
 JS::GCPtr<Layout::Node> SVGAElement::create_layout_node(NonnullRefPtr<CSS::StyleProperties> style)
 {
     return heap().allocate_without_realm<Layout::SVGGraphicsBox>(document(), *this, move(style));

diff --git a/Userland/Libraries/LibWeb/SVG/SVGAElement.h b/Userland/Libraries/LibWeb/SVG/SVGAElement.h
@@ -17,9 +17,11 @@ class SVGAElement final : public SVGGraphicsElement {
 public:
     virtual ~SVGAElement() override;
 
-    SVGAElement(DOM::Document&, DOM::QualifiedName);
-
     virtual JS::GCPtr<Layout::Node> create_layout_node(NonnullRefPtr<CSS::StyleProperties>) override;
+
+private:
+    SVGAElement(DOM::Document&, DOM::QualifiedName);
+    virtual void initialize(JS::Realm&) override;
 };
 
 }