Skip to content

Commit

Permalink
LibWeb: Consider resource: URLs to be trustworthy and non-opaque
Browse files Browse the repository at this point in the history
This makes icons once again load in the directory listings
  • Loading branch information
circl-lastname authored and ADKaster committed Jun 26, 2024
1 parent cb629e1 commit d14888f
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
3 changes: 2 additions & 1 deletion Userland/Libraries/LibWeb/DOMURL/DOMURL.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -548,7 +548,8 @@ HTML::Origin url_origin(URL::URL const& url)
}

// -> "file"
if (url.scheme() == "file"sv) {
// AD-HOC: Our resource:// is basically an alias to file://
if (url.scheme() == "file"sv || url.scheme() == "resource"sv) {
// Unfortunate as it is, this is left as an exercise to the reader. When in doubt, return a new opaque origin.
// Note: We must return an origin with the `file://' protocol for `file://' iframes to work from `file://' pages.
return HTML::Origin(url.scheme().to_byte_string(), String {}, 0);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,8 @@ Trustworthiness is_origin_potentially_trustworthy(HTML::Origin const& origin)
}

// 6. If origin’s scheme is "file", return "Potentially Trustworthy".
if (origin.scheme() == "file"sv)
// AD-HOC: Our resource:// is basically an alias to file://
if (origin.scheme() == "file"sv || origin.scheme() == "resource"sv)
return Trustworthiness::PotentiallyTrustworthy;

// 7. If origin’s scheme component is one which the user agent considers to be authenticated, return "Potentially Trustworthy".
Expand Down

0 comments on commit d14888f

Please sign in to comment.