LibWeb: Compute accessible names for hidden/hidden-but-referenced nodes #2294
+501
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sideshowbarker
force-pushed
the
accname-name-comp_hidden_not_referenced
branch
from
610f287
to
6cac6d8
Compare
This change implements full support for the “A. Hidden Not Referenced” step at https://w3c.github.io/accname/#step2A in the “Accessible Name and Description Computation” spec — including handling all hidden nodes that must be ignored, as well as handling hidden nodes that, for the purposes of accessible-name computation, must not be ignored (due to having aria-labelledby/aria-describedby references from other nodes). Otherwise, without this change, not all cases of hidden nodes get ignored as expected, while cases of nodes that are hidden but that have aria-labelledby/aria-describedby references from other nodes get unexpectedly ignored.
sideshowbarker
force-pushed
the
accname-name-comp_hidden_not_referenced
branch
from
6cac6d8
to
ff18f72
Compare
This change makes Ladybird give the value of the aria-label attribute the correct precedence for accessible-name computation required by the “Accessible Name and Description Computation” and HTML-AAM specs and by the corresponding WPT tests. Otherwise, without this change, Ladybird fails some of the WPT subtests of the test at https://wpt.fyi/results/accname/name/comp_label.html.
sideshowbarker
force-pushed
the
accname-name-comp_hidden_not_referenced
branch
from
862716e
to
4c06624
Compare
|
Hello! One or more of the commit messages in this PR do not match the Ladybird code submission policy, please check the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change implements full support for the “A. Hidden Not Referenced” step at https://w3c.github.io/accname/#step2A in the “Accessible Name and Description Computation” spec — including handling all hidden nodes that must be ignored, as well as handling hidden nodes that, for the purposes of accessible-name computation, must not be ignored (due to having
aria-labelledby/aria-describedbyreferences from other nodes).Otherwise, without this change, not all cases of hidden nodes get ignored as expected, while cases of nodes that are hidden but that have
aria-labelledby/aria-describedbyreferences from other nodes get unexpectedly ignored.For the tests at https://wpt.fyi/results/accname/name?product=ladybird, this change gets us passing:
comp_labelledby_hidden_nodes.htmltestcomp_hidden_not_referenced.htmltestOtherwise, without this change, we fail all those tests.
Additionally, a separate commit here makes us give the value of the aria-label attribute the correct precedence for accessible-name computation required by the “Accessible Name and Description Computation” and HTML-AAM specs and by the corresponding WPT tests.
That gets us passing all 131 subtests in the
comp_label.htmltest at https://wpt.fyi/results/accname/name?product=ladybird