LibCore: Support IPv6 for TCP and UDP connection

[xlmnxp]

This PR will add IPv6 support to Ladybird and give priority to IPv6 over IPv4
the PR still missing support of RFC 8305 and maybe we can add it as Phase 2

[xlmnxp]

this PR will; fix #90 and it same as #273 ( but with cleaner git history :) )

[circl-lastname]

CI is failing unfortunately, does it build on your machine?

[xlmnxp]

CI is failing unfortunately, does it build on your machine?

yes

[circl-lastname]

Have you tried rebased onto the latest master?

[xlmnxp]

Have you tried rebased onto the latest master?

do I have to? It build successfully on my machine

[circl-lastname]

do I have to? It build successfully on my machine

If it doesn't build on CI it likely won't build on other's machines, please do try, this is the error reported by CI

In file included from /home/runner/work/ladybird/ladybird/Tests/LibTLS/TestTLSHandshake.cpp:13:
In file included from /home/runner/work/ladybird/ladybird/Userland/Libraries/LibTLS/TLSv12.h:14:
In file included from /home/runner/work/ladybird/ladybird/Userland/Libraries/LibCore/Socket.h:15:
/home/runner/work/ladybird/ladybird/Userland/Libraries/LibCore/SocketAddress.h:118:10: error: explicitly defaulted equality comparison operator is implicitly deleted [-Werror,-Wdefaulted-function-deleted]
  118 |     bool operator==(SocketAddress const& other) const = default;
      |          ^
/home/runner/work/ladybird/ladybird/Userland/Libraries/LibCore/SocketAddress.h:127:7: note: defaulted 'operator==' is implicitly deleted because there is no viable 'operator==' for member 'm_ip_address'
  127 |     } m_ip_address { IPv4Address() };
      |       ^
/home/runner/work/ladybird/ladybird/Userland/Libraries/LibCore/SocketAddress.h:118:57: note: replace 'default' with 'delete'
  118 |     bool operator==(SocketAddress const& other) const = default;
      |                                                         ^~~~~~~
      |                                                         delete
/home/runner/work/ladybird/ladybird/Userland/Libraries/LibCore/SocketAddress.h:119:10: error: explicitly defaulted equality comparison operator is implicitly deleted [-Werror,-Wdefaulted-function-deleted]
  119 |     bool operator!=(SocketAddress const& other) const = default;
      |          ^
/home/runner/work/ladybird/ladybird/Userland/Libraries/LibCore/SocketAddress.h:119:10: note: defaulted 'operator!=' is implicitly deleted because it would invoke a deleted comparison function
/home/runner/work/ladybird/ladybird/Userland/Libraries/LibCore/SocketAddress.h:118:10: note: explicitly defaulted function was implicitly deleted here
  118 |     bool operator==(SocketAddress const& other) const = default;
      |          ^
/home/runner/work/ladybird/ladybird/Userland/Libraries/LibCore/SocketAddress.h:127:7: note: defaulted 'operator==' is implicitly deleted because there is no viable 'operator==' for member 'm_ip_address'
  127 |     } m_ip_address { IPv4Address() };
      |       ^
/home/runner/work/ladybird/ladybird/Userland/Libraries/LibCore/SocketAddress.h:119:57: note: replace 'default' with 'delete'
  119 |     bool operator!=(SocketAddress const& other) const = default;
      |                                                         ^~~~~~~
      |                                                         delete
2 errors generated.

[xlmnxp]

do I have to? It build successfully on my machine

If it doesn't build on CI it likely won't build on other's machines, please do try, this is the error reported by CI

In file included from /home/runner/work/ladybird/ladybird/Tests/LibTLS/TestTLSHandshake.cpp:13:
In file included from /home/runner/work/ladybird/ladybird/Userland/Libraries/LibTLS/TLSv12.h:14:
In file included from /home/runner/work/ladybird/ladybird/Userland/Libraries/LibCore/Socket.h:15:
/home/runner/work/ladybird/ladybird/Userland/Libraries/LibCore/SocketAddress.h:118:10: error: explicitly defaulted equality comparison operator is implicitly deleted [-Werror,-Wdefaulted-function-deleted]
  118 |     bool operator==(SocketAddress const& other) const = default;
      |          ^
/home/runner/work/ladybird/ladybird/Userland/Libraries/LibCore/SocketAddress.h:127:7: note: defaulted 'operator==' is implicitly deleted because there is no viable 'operator==' for member 'm_ip_address'
  127 |     } m_ip_address { IPv4Address() };
      |       ^
/home/runner/work/ladybird/ladybird/Userland/Libraries/LibCore/SocketAddress.h:118:57: note: replace 'default' with 'delete'
  118 |     bool operator==(SocketAddress const& other) const = default;
      |                                                         ^~~~~~~
      |                                                         delete
/home/runner/work/ladybird/ladybird/Userland/Libraries/LibCore/SocketAddress.h:119:10: error: explicitly defaulted equality comparison operator is implicitly deleted [-Werror,-Wdefaulted-function-deleted]
  119 |     bool operator!=(SocketAddress const& other) const = default;
      |          ^
/home/runner/work/ladybird/ladybird/Userland/Libraries/LibCore/SocketAddress.h:119:10: note: defaulted 'operator!=' is implicitly deleted because it would invoke a deleted comparison function
/home/runner/work/ladybird/ladybird/Userland/Libraries/LibCore/SocketAddress.h:118:10: note: explicitly defaulted function was implicitly deleted here
  118 |     bool operator==(SocketAddress const& other) const = default;
      |          ^
/home/runner/work/ladybird/ladybird/Userland/Libraries/LibCore/SocketAddress.h:127:7: note: defaulted 'operator==' is implicitly deleted because there is no viable 'operator==' for member 'm_ip_address'
  127 |     } m_ip_address { IPv4Address() };
      |       ^
/home/runner/work/ladybird/ladybird/Userland/Libraries/LibCore/SocketAddress.h:119:57: note: replace 'default' with 'delete'
  119 |     bool operator!=(SocketAddress const& other) const = default;
      |                                                         ^~~~~~~
      |                                                         delete
2 errors generated.

I don't receive that errors, is it because the version of gcc?

[circl-lastname]

Have you rebased your local branch onto the latest master?

[ladybird-bot]

Hello!

One or more of the commit messages in this PR do not match the Ladybird code submission policy, please check the lint_commits CI job for more details on which commits were flagged and why.
Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR.

[circl-lastname]

I said "rebase" not "merge" :(

[xlmnxp]

I said "rebase" not "merge" :(

I will fix it later today

[xlmnxp]

I said "rebase" not "merge" :(

fixed

[xlmnxp]

Before	After

[ghost]

Do you guys need any help testing out features for this new browser? Get Outlook for iOS<https://aka.ms/o0ukef>

…

________________________________ From: Andrew Kaster ***@***.***> Sent: Friday, July 5, 2024 12:07:12 PM To: LadybirdBrowser/ladybird ***@***.***> Cc: Subscribed ***@***.***> Subject: Re: [LadybirdBrowser/ladybird] LibCore: Support IPv6 for TCP and UDP connection (PR #276) @ADKaster approved this pull request. — Reply to this email directly, view it on GitHub<#276 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BFWGZYLEGOV6AQR4VSMJICTZK3ADBAVCNFSM6AAAAABJ2UHCMOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNRQHE4DEMRVHA>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>