LibCore: Several bug fixes for EventLoopImplementationWindows #3188
+42
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! One or more of the commit messages in this PR do not match the Ladybird code submission policy, please check the |
and unregister_timer in EventLoopManagerWindows Destructors for thread local objects are called before destructors of global not thread local objects. This is a partial stack of the problem, thread_data is already destroyed at this point: >WebContent.exe!Core::ThreadData::the WebContent.exe!Core::EventLoopManagerWindows::unregister_notifier WebContent.exe!Core::EventLoop::unregister_notifier WebContent.exe!Core::Notifier::set_enabled WebContent.exe!Core::LocalSocket::~LocalSocket WebContent.exe!Requests::RequestClient::~RequestClient WebContent.exe!Web::`dynamic atexit destructor for 's_resource_loader'
has pending events in EventLoopImplementationWindows This matches the behavior of the Linux version: https://github.com/LadybirdBrowser/ladybird/blob/911cd4aefd0c/Libraries/LibCore/EventLoopImplementationUnix.cpp#L371
This fixes the problem when none of the timers or notifiers get executed if wake() is called frequently. Note that calling WaitForMultipleObjects repeatedly until it fails will not work because rapidly firing timer can get all the attention. That's why I check every event individually with WaitForSingleObject. This behavior matches EventLoopImplementationUnix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.