-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LibWeb: Implement dialog.requestClose() #3280
base: master
Are you sure you want to change the base?
Conversation
The test passes when running in the browser and when imported, but if I run with the test runner I get same error as CI, it seems something is flaky and can lead to two close events being fired (at least according to the test) It makes use of abort signal and I'm wondering if there's an issue with Ladybird's impl? |
7562e5d
to
d96ca7f
Compare
Your pull request has conflicts that need to be resolved before it can be reviewed and merged. Make sure to rebase your branch on top of the latest |
d96ca7f
to
406c68d
Compare
Going to move some of these changes to a PR that introduces all the popover=hint changes at once as they're orthogonal to this change. |
406c68d
to
c8f3b65
Compare
c8f3b65
to
19d887e
Compare
Your pull request has conflicts that need to be resolved before it can be reviewed and merged. Make sure to rebase your branch on top of the latest |
Depends on #3354
See https://html.spec.whatwg.org/multipage/interaction.html#dom-closewatcher-requestclose
Can manually test using https://wpt.live/html/semantics/interactive-elements/the-dialog-element/dialog-requestclose.html where it passes all tests.
If I import the test it's flaky and sometimes fails on test runner.