Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibWeb: Add inline-size containment for replaced elements #3344

Closed
Closed
Changes from 1 commit
Commits
Show all changes
213 commits
Select commit Hold shift + click to select a range
5fe9b14
LibWeb: Implement CSS 'isolation' property
Psychpsyo Jan 11, 2025
37093cc
LibWeb/Bindings: Define constructor properties in the correct order
shannonbooth Jan 11, 2025
e4065bc
LibWeb: Emit comment token for unterminated bogus comments on EOF
tcl3 Jan 6, 2025
d19ee6d
LibWeb/HTML: Pass user_involvement through navigables code
AtkinsSJ Jan 7, 2025
0cd1e9d
LibWeb/DOM: Move "stop intersection observing..." code into a method
AtkinsSJ Jan 7, 2025
e0b3760
LibWeb/HTML: Update Navigable::navigate spec steps
AtkinsSJ Jan 7, 2025
2ec11c5
LibWeb/HTML: Stop observing lazy-loaded iframes when navigating
AtkinsSJ Jan 7, 2025
b2cbed0
LibWeb/HTML: Halt navigation if navigate event returns false
AtkinsSJ Jan 7, 2025
9b955f3
LibWeb: Wait until ReadyState is complete before detaching HTML parser
tcl3 Jan 6, 2025
799ddff
LibWeb: Use DocumentLoadTimingInfo values in PerformanceTiming interface
tcl3 Jan 6, 2025
0a541f4
LibCrypto: Add useful macros and classes for working with OpenSSL
devgianlu Dec 21, 2024
97ab447
LibCrypto: Implement Ed448
devgianlu Dec 21, 2024
321a6d4
LibCrypto: Add Ed448 OID to know algorithm identifiers
devgianlu Dec 21, 2024
7a58b65
LibWeb: Add Ed448 support in WebCryptoAPI
devgianlu Dec 21, 2024
36b21a8
LibWeb: Preserve `indeterminate` value when cloning `HTMLInputElement`
tcl3 Jan 5, 2025
63f48a7
LibWeb: Set dirty checkedness flag when setting `checked` IDL attribute
tcl3 Jan 5, 2025
2dd1ce6
IDLGenerators: Set Iterator `@@toStringTag` with correct descriptor
tcl3 Jan 11, 2025
4cc97b0
LibURL+LibWeb: Make URL::basic_parse return an Optional<URL>
shannonbooth Jan 9, 2025
440b072
LibWeb: Return a representation of an 'Agent' in 'relevant agent'
shannonbooth Jan 4, 2025
0e5d1aa
LibWebView: Fix capitalization in devtools
Psychpsyo Jan 11, 2025
de4ceac
LibWeb: Make node cloning methods const
tcl3 Jan 11, 2025
9f40e21
LibWeb: Clone all attribute properties when cloning a single node
tcl3 Jan 11, 2025
9342459
Meta/CMake: Use simple string match to find relevant vcpkg triplets
tcl3 Jan 10, 2025
e61f6a9
LibWeb: Verify element namespace in DOM::create_element()
Psychpsyo Jan 9, 2025
1adf909
LibWeb: Remove outdated FIXME about missing HTML event names
trflynn89 Jan 11, 2025
7dcfe46
LibWeb: Remove the initialize_strings methods
trflynn89 Jan 11, 2025
fcb0e59
LibWebView: Avoid replication of the HTML namespace string
trflynn89 Jan 11, 2025
84b893f
LibCrypto: Make `RSA::generate_key_pair` return `ErrorOr`
devgianlu Dec 23, 2024
385d8d1
LibCrypto: Remove default key size for `RSA::generate_key_pair`
devgianlu Dec 23, 2024
eb94196
LibCrypto: Make `PKSystem` methods return `ErrorOr`
devgianlu Dec 23, 2024
02d9182
LibCrypto: Refactor OpenSSL RAII wrappers to a macro
devgianlu Dec 24, 2024
19cb66f
LibCrypto: Add methods to convert OpenSSL BN <-> UnsignedBigInteger
devgianlu Dec 23, 2024
d72fb82
LibCrypto: Use OpenSSL to generate RSA keys
devgianlu Dec 23, 2024
03cb339
LibWeb/Bindings: Generate undefined in a union as 'Empty'
shannonbooth Jan 12, 2025
9d2e023
LibWeb/HTML: Fix crash creating canvas pattern without context
shannonbooth Jan 11, 2025
650cb8e
LibWeb/HTML: Include better information in 'report an exception' event
shannonbooth Jan 12, 2025
669af12
UI: Prevent crash when right clicking on an unloaded image
Gingeh Jan 10, 2025
6a5d757
LibWeb: Check for missing node or invalid query in obtain_theme_color
Gingeh Jan 10, 2025
ed73377
LibWeb: Allow color keywords in theme-color metadata
Gingeh Jan 10, 2025
8a9bb84
LibWeb: Don't crash when upgrading custom element with a bad constructor
tcl3 Jan 12, 2025
385c0c7
LibWeb/CSS: Replace Parser "current property" with a stack of contexts
AtkinsSJ Jan 6, 2025
e98e275
LibWeb/CSS: Give calc() a CalculationContext for resolving percentages
AtkinsSJ Jan 8, 2025
fae0654
LibWeb/CSS: Remove CSSNumericType::matches_resolution_percentage()
AtkinsSJ Jan 9, 2025
1e4d667
LibWeb/CSS: Mark transform property as resolving percentages as lengths
AtkinsSJ Jan 9, 2025
d72b05c
LibWeb/CSS: Use CalcSV's context to determine what percentages are
AtkinsSJ Jan 9, 2025
71adc25
LibWeb: Implement CSS 'isolation' property
Psychpsyo Jan 11, 2025
07daadd
LibWeb: Fix CSS tag seletor case sensitivity for SVG elements
Psychpsyo Jan 8, 2025
2e2a61f
LibWeb: Update add_libweb_test.py to support Screenshot, Ref, and Layout
noahmbright Oct 9, 2024
11e5210
CI: Remove conditional execution based on changed paths
gmta Jan 13, 2025
1084c0d
LibCrypto: Make `PKSystem` methods return a `ByteBuffer` directly
devgianlu Dec 25, 2024
84cd6ad
LibCrypto: Move hash constructors out of line
devgianlu Jan 12, 2025
d12895b
LibCrypto: Move OpenSSL RAII helper methods out of line
devgianlu Jan 12, 2025
5a238f2
LibCrypto: Remove OpenSSL as a public header dependency
devgianlu Jan 12, 2025
0fa96de
LibCrypto: Use OpenSSL for RSA encryption and decryption
devgianlu Dec 23, 2024
92ddd6b
LibCrypto: Make RSA class easily configurable
devgianlu Dec 25, 2024
83fc479
LibWeb: Add RSA-OAEP WPT tests
devgianlu Dec 25, 2024
172ba9f
LibCrypto+LibTLS: Replace `RSA_PKCS1-EMSA` implementation
devgianlu Dec 25, 2024
3870fa4
LibCrypto+LibWeb: Replace `RSA_OAEP-EME` implementation
devgianlu Dec 25, 2024
9e29dec
LibCrypto: Remove old unused padding schemes and codes
devgianlu Dec 25, 2024
bd1b702
LibWeb: Fix insert/delete rule invalidation for adopted style sheets
kalenikaliaksandr Jan 10, 2025
c3de288
LibWeb: Fix CSS clip-path ignoring scroll position
Psychpsyo Jan 13, 2025
ccfb362
AK: Show executable name in rich debug format on Windows
stasoid Jan 2, 2025
985b80d
LibWeb: Improve <select> dropdown position
Psychpsyo Jan 14, 2025
3557edf
LibWeb: Turn IDB internal Key into a GC type
stelar7 Jan 8, 2025
1c7b9ae
LibWeb: Move IDBDatabase::close out of line
stelar7 Jan 8, 2025
bbd663f
LibWeb: Implement IDBKeyRange
stelar7 Jan 8, 2025
13c1811
LibWeb: Import WPT tests for IDBKeyRange
stelar7 Jan 8, 2025
ab0febb
LibWeb: Rename ConnectionQueue to RequestList
stelar7 Jan 8, 2025
37976bd
LibWeb: Mark a few calls to set_attribute as infallible
trflynn89 Jan 15, 2025
88d292f
LibJS: Parse dates like "Wednesday, Jan 15, 2025"
shannonbooth Jan 15, 2025
a7823c2
LibWeb/HTML: Only use maxlength <input> attribute when applicable
shannonbooth Jan 15, 2025
7ea6f1b
LibWeb/WebGL2: Implement MAX_COMBINED_VERTEX_UNIFORM_COMPONENTS
ADKaster Jan 14, 2025
50e7c5b
LibWeb/WebGL2: Implement MAX_COMBINED_FRAGMENT_UNIFORM_COMPONENTS
ADKaster Jan 14, 2025
7f60a8d
WebContent+LibWeb: Add an option to disable painting viewport scrollbars
tcl3 Dec 16, 2024
3c94010
LibWebView: Add an option to disable painting viewport scrollbars
tcl3 Dec 16, 2024
1668f0f
WebDriver: Disable scrollbar painting when launching the browser
tcl3 Dec 17, 2024
d9fdcf2
LibWeb/XHR: Isomorphic decode accessing XMLHttpRequest response headers
shannonbooth Jan 3, 2025
d4eacc5
LibWeb/HTML: Scroll to the fragment before loading the document
shannonbooth Jan 15, 2025
2f8d183
Docs: Add info about --enable-idl-tracing flag
matan-h Dec 16, 2024
a346a79
LibWeb/CSS: Properly classify calculations inside transform functions
AtkinsSJ Jan 13, 2025
08f56d5
LibWeb: Use `AttributeNames::value` rather than StringView literals
tcl3 Jan 13, 2025
360463d
LibWeb: Fetch source file when HTMLTrackElement src attribute changes
tcl3 Jan 13, 2025
f189ec7
LibWeb/Fetch: Remove FIXME for since fixed spec bug
shannonbooth Jan 15, 2025
9c0a8a4
LibWeb: Align AudioContext constructor with current spec steps
tcl3 Jan 9, 2025
f2b5c8f
LibWeb: Align OfflineAudioContext constructors with current spec steps
tcl3 Jan 9, 2025
0a68f6a
LibWeb: Add missing #include to InputEventsTarget.h
trflynn89 Jan 16, 2025
fae024b
LibUnicode: Consistently reject out-of-bounds segmenter indices
trflynn89 Jan 16, 2025
20bcf09
CI: Do not insinuate PRs can be reopened in stalebot's close message
gmta Jan 16, 2025
cbc24ce
headless-browser: Add support for crash tests
tcl3 Nov 22, 2024
1b1b6d9
Tests: Convert existing text test to crash test
tcl3 Nov 23, 2024
5d5c59f
Meta: Support importing WPT crash tests
tcl3 Nov 23, 2024
f515dab
LibJS: Do not override the timeZoneName option in Intl.DateTimeFormat
trflynn89 Jan 16, 2025
8ee4910
LibJS: Refer to RFC 9557 instead of ISO 8601 where appropriate
trflynn89 Jan 16, 2025
175fbd7
LibJS: Convert errant MUST to TRY in Temporal.PlainDateTime.with
trflynn89 Jan 16, 2025
211fee5
LibJS: Adjust ad-hoc clamping behavior in RegulateISODate
trflynn89 Jan 16, 2025
5eb6fc6
LibWeb: Use finalize for cleaning up all navigables
shannonbooth Jan 17, 2025
683efe3
LibWeb/HTML: Fix grammar in spec note for error checking serialization
shannonbooth Jan 17, 2025
9934292
LibWeb: Don't add extra gap when placing flex items in reverse order
aplefull Jan 16, 2025
d3a78bc
LibWeb/WebAudio: Define and partially implement AnalyserNode
noahmbright Sep 18, 2024
7e51bfd
LibWeb/CSS: Return TransformationStyleValue values by reference
AtkinsSJ Jan 15, 2025
ba30ed5
LibWeb/CSS: Move TransformationSV -> Transformation code into TSV
AtkinsSJ Jan 15, 2025
86eaa09
LibWeb/CSS: Merge ScaleStyleValue into TransformationStyleValue
AtkinsSJ Jan 15, 2025
3348e56
LibWeb/CSS: Merge TranslationStyleValue into TransformationStyleValue
AtkinsSJ Jan 15, 2025
10bd5f8
LibWeb/CSS: Merge RotationStyleValue into TransformationStyleValue
AtkinsSJ Jan 15, 2025
acec233
LibWeb: Update the HTMLDetailsElement attribute change steps
trflynn89 Jan 15, 2025
77bb914
LibWeb: Implement the exclusive <details> accordion
trflynn89 Jan 15, 2025
365ec94
AK: Add a const iterator for COWVector
alimpfard Jan 15, 2025
a952647
LibRegex: Avoid use-after-move of trivial object
alimpfard Jan 15, 2025
1c1b6cd
LibRegex: Don't repeat the same fork again
alimpfard Jan 15, 2025
221dcc6
LibCrypto: Implement `RSA_PSS_EMSA` with OpenSSL
devgianlu Dec 25, 2024
2c6030d
LibWeb: Support `RSA-PSS` in WebCryptoAPI
devgianlu Dec 25, 2024
6b103f2
LibWeb: Support `RSASSA-PKCS1-v1_5` in WebCryptoAPI
devgianlu Dec 26, 2024
95ddcb3
LibWeb: Always return a `KeyAlgorithm` from `RsaHashedKeyAlgorithm`
devgianlu Dec 26, 2024
5c3bf44
LibJS: Propagate direct eval presence if the current scope is screwed
Lubrsi Jan 17, 2025
5773b8f
LibJS: Use correct this value for tagged template literals with members
Lubrsi Jan 16, 2025
523b55a
LibWeb: Add `MediaElementAudioSourceNode` interface
tcl3 Jan 15, 2025
a290d3d
LibWeb: Add `AudioContext.createMediaElementSource()` factory method
tcl3 Jan 15, 2025
fcead4f
LibJS: Alphabetically sort the list of well-known symbols
trflynn89 Jan 16, 2025
3041b59
LibJS: Bring the explicit resource management implementation up to date
trflynn89 Jan 16, 2025
fe09281
LibJS: Implement the AsyncDisposableStack interface
trflynn89 Jan 17, 2025
6b82de9
LibWeb: Add `StereoPannerNode` interface
tcl3 Jan 17, 2025
cbee19e
LibWeb: Add `BaseAudioContext.createStereoPanner()` factory method
tcl3 Jan 17, 2025
ccc8770
LibWeb/WebGL2: Implement a bunch of parameters read by CreepJS
Lubrsi Jan 17, 2025
2c2a92c
LibWeb/Streams: Ensure pending pull into's objects are visited by GC
shannonbooth Jan 17, 2025
762cb97
Tests: Add some tests for partial layout tree updates
awesomekling Jan 13, 2025
936a10a
LibWeb: Add TreeNode<T>::replace_child(new_child, old_child)
awesomekling Jan 11, 2025
1e56d48
LibWeb: Don't (anonymously) wrap table boxes that are already wrapped
awesomekling Jan 11, 2025
468fabe
LibWeb: Implement partial layout tree updates
awesomekling Jan 13, 2025
7ecc7ed
LibWeb: Enable partial layout tree update in a bunch of cases
awesomekling Jan 15, 2025
7ab7822
AK: Remove default parameter from StringBuilder's constructor
trflynn89 Jan 18, 2025
611988e
Meta: Add an overlay port for ICU
trflynn89 Jan 18, 2025
ad2bfd0
LibJS: Ensure tests using the "ar" locale use the "arab" number system
trflynn89 Jan 18, 2025
46fe24c
Meta+LibUnicode+LibJS: Upgrade to ICU 76.1
trflynn89 Jan 18, 2025
987e7c4
LibWeb: Invalidate entire layout tree on SVG <use> clone instantiation
awesomekling Jan 19, 2025
ccc1820
LibWeb/SVG: Fix crash when SVG use element is used on an external SVG
shannonbooth Jan 18, 2025
8c62758
LibWeb: Resolve `SVGImageElement` source URL correctly
tcl3 Jan 19, 2025
6432571
LibWeb: Use correct automation rate for AudioBufferSourceNode parameters
tcl3 Jan 19, 2025
f043de3
LibWeb/WebAudio: Implement automation rate constraints
tcl3 Jan 19, 2025
e516b35
LibWeb: Update the select label when option's children are changed
Gingeh Jan 10, 2025
975ddbc
LibWeb: Use invalidation sets to reduce style recalculation
kalenikaliaksandr Jan 12, 2025
59a6cbb
LibWeb: Use invalidation sets for id attribute style invalidation
kalenikaliaksandr Jan 18, 2025
319cac3
LibWeb: Expand invalidation sets usage to any attribute change
kalenikaliaksandr Jan 19, 2025
08684a6
LibWeb: Do not run microtasks when the event loop is paused
trflynn89 Jan 19, 2025
39b45d1
LibWeb/HTML: Do not use macro to implement MessagePort event handlers
shannonbooth Dec 14, 2024
92d2035
LibWeb/HTML: Start MessagePort's port messsge queue in onmessage setter
shannonbooth Dec 15, 2024
2875211
LibWeb/HTML: Pubically expose entangled port and post message steps
shannonbooth Dec 15, 2024
840e59b
LibWeb/HTML: Enable callbacks in postMessage deserialization
shannonbooth Dec 21, 2024
c4764b7
LibXml: Notify listener when doctype is parsed
mikiubo Jan 1, 2025
b4e7462
LibWeb: Only reload link on rel change if it became a stylesheet
Gingeh Jan 20, 2025
e8683fe
LibWeb: Use invalidation sets for "style" attribute invalidation
kalenikaliaksandr Jan 19, 2025
8ab9d5d
LibWeb: Delete "names used in attribute selectors" from SelectorInsights
kalenikaliaksandr Jan 19, 2025
6e0e60b
UI/Qt: Add '.com' to the URL if CTRL is held while pressing return
rok-povsic Jan 19, 2025
edf4b91
LibWeb: Allow partial update of SVG subtrees in layout tree
awesomekling Jan 20, 2025
b3e9fd9
LibWeb: Implement `formData()` for "multipart/form-data"
F3n67u Dec 25, 2024
ecfb8b8
LibWeb: Make SVGSVGElement.getElementById() return Element? (nullable)
awesomekling Jan 21, 2025
c6660a9
LibWeb: Require existing Selection for `.execCommand("selectAll")`
gmta Jan 20, 2025
93dabe2
LibWeb/HTML: Support blob URLs in HTMLLinkElement
shannonbooth Jan 21, 2025
a754e50
AK: Introduce an as_if<OutputType>() cast
trflynn89 Jan 20, 2025
d8bcefa
LibJS: Add missing spec prose to FinishLoadingImportedModule
trflynn89 Jan 20, 2025
05ddd64
LibJS: Update the noted grammar for ImportDeclaration
trflynn89 Jan 20, 2025
6f0f5e9
LibJS: Do not attempt to link modules which have failed to load
trflynn89 Jan 20, 2025
b821773
LibJS: Implement InnerModuleLoading as a free function
trflynn89 Jan 20, 2025
546fd0a
LibJS: Do not consume "with" tokens in import statements as identifiers
trflynn89 Jan 20, 2025
14a8c4c
LibJS: Remove support for the "assert" keyword for import attributes
trflynn89 Jan 20, 2025
0431027
LibWeb: Accept TableWrapper as containing block for abspos items
InvalidUsernameException Jan 19, 2025
aec9161
LibWeb: Calculate image size in CSS pixels
InvalidUsernameException Dec 19, 2024
8832159
LibWeb+UI: Add internals API to set browser zoom
InvalidUsernameException Dec 23, 2024
ac2811b
Tests: Add tests that verify object-fit and -position with zoom
InvalidUsernameException Dec 23, 2024
58d5f99
LibGC: Add ability to construct RootVector<T> from a span of T
awesomekling Jan 21, 2025
c0160e6
LibWeb: Iterate over a copy of associated form controls in form.reset()
awesomekling Jan 21, 2025
2bfae8e
AK+Everywhere: Rename `verify_cast` to `as`
trflynn89 Jan 21, 2025
272e6b6
LibWeb/DOM: Return Document's Origin by reference
AtkinsSJ Jan 5, 2025
f35eda1
LibURL: Gracefully handle a host having no public suffix
AtkinsSJ Jan 7, 2025
a0bebbd
LibWeb/HTML: Update Document::create_and_initialize() to latest spec
AtkinsSJ Jan 5, 2025
07bf827
LibWeb/HTML: Update Navigable::choose_a_navigable() to latest spec
AtkinsSJ Jan 5, 2025
e974e64
LibWeb: Use `as_if` in Editing API where useful
gmta Jan 21, 2025
0333479
LibWeb: Disallow Editing API calls on non-HTML documents
tcl3 Jan 21, 2025
dfeab8b
LibURL+LibWeb+LibIPC: Represent blob URL entry's object using structs
shannonbooth Jan 19, 2025
f128673
LibWeb/Storage: Add a storage key getter that takes a URL::Origin
shannonbooth Jan 19, 2025
9836269
LibWeb: Partition Blob URL fetches by Storage Key
shannonbooth Jan 19, 2025
a4a9766
LibWeb: Cache the margin box rect for floating boxes
Gingeh Jan 21, 2025
1a78db3
LibWeb: Optimize style invalidation for presentational hint attributes
kalenikaliaksandr Jan 21, 2025
05a051a
LibWeb: Don't include changed attribute twice in `changed_properties`
kalenikaliaksandr Jan 21, 2025
47f7041
LibWebView: Consider wss a secure scheme for Secure cookies
Lubrsi Jan 9, 2025
1f476ea
LibWeb: Send cookies in the WebSocket handshake
Lubrsi Jan 9, 2025
07bb7dc
LibWeb: Respect subarrays in TextEncoder::encode_into
Lubrsi Jan 9, 2025
e135543
LibWeb/WebGL: Track the shaders attached to a program
Lubrsi Jan 9, 2025
eba8660
LibWeb/WebGL: Implement getAttachedShaders
Lubrsi Jan 9, 2025
df3c175
LibWeb/WebGL: Tell ANGLE to create a WebGL compatible EGL context
Lubrsi Jan 10, 2025
0670c4d
LibWeb/WebGL: Request GL_ANGLE_instanced_arrays extension when required
Lubrsi Jan 10, 2025
42e3802
LibWeb/WebGL: Implement OES_vertex_array_object extension
Lubrsi Jan 9, 2025
c613519
LibWeb/WebGL: Make getExtension spec-compliant
Lubrsi Jan 10, 2025
a8a4399
LibWeb/WebGL: Move extensions into their own folder
Lubrsi Jan 10, 2025
a29e9e4
LibWeb/WebGL: Implement WEBGL_draw_buffers extension
Lubrsi Jan 10, 2025
34c44b1
LibWeb/WebGL: Map DEPTH_STENCIL to DEPTH24_STENCIL8 for WebGL 1 too
Lubrsi Jan 10, 2025
a99facf
LibWeb/WebGL: Implement pixel format conversion for TexImageSource
Lubrsi Jan 10, 2025
e22d272
LibWeb/WebGL: Map WebGL extensions to the required extensions
Lubrsi Jan 17, 2025
a4f0daa
LibJS: Parse dates like "2025-01-13 00:00:00.000"
Lubrsi Jan 17, 2025
6a6c284
LibJS: Parse dates like "2021-04-21T15:00:00+0000"
Lubrsi Jan 17, 2025
cd1497e
LibWeb: Fix context menu and select dropdown position in iframe
Psychpsyo Jan 14, 2025
be34d79
LibWeb: Remove unused 'host_is_domain'
shannonbooth Jan 22, 2025
a84cdfd
LibWeb: Remove uneeded exception handling for DOMURL
shannonbooth Jan 22, 2025
e5473b6
LibWeb: Update revokeObjectURL for reported spec bugs
shannonbooth Jan 22, 2025
5cb880c
LibWeb: Return OptionalNone from DOMURL::parse on failure
shannonbooth Jan 22, 2025
a8075c3
UI/Qt: Add copy/paste/select actions to the InspectorWidget
aplefull Jan 19, 2025
9939dc9
LibWeb: Add `TreeNode::remove()`
gmta Jan 15, 2025
5f8826a
LibGfx: Add `Rect::unite()`
gmta Jan 15, 2025
6389bc4
LibWeb: Support inserting non-inline elements into inline elements
gmta Jan 15, 2025
a839ab7
LibWeb: Simplify hit testing coordinate calculations
gmta Jan 20, 2025
56d772f
LibWeb: Reorder paintable hit-testing to account for `pointer-events`
gmta Jan 21, 2025
0d70027
LibJS+LibGC: Run FinalizationRegistry cleanup host hook *after* GC
awesomekling Jan 23, 2025
23af8c8
LibWeb: Implement CSS 'contain' property
Psychpsyo Jan 18, 2025
a483cd4
LibWeb: Add inline-size containment for replaced elements
Psychpsyo Jan 23, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
LibWeb: Emit comment token for unterminated bogus comments on EOF
  • Loading branch information
tcl3 authored and Psychpsyo committed Jan 23, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit e4065bc686041e8437f6dd5471e58744cf479c26
4 changes: 2 additions & 2 deletions Libraries/LibWeb/HTML/Parser/HTMLTokenizer.cpp
Original file line number Diff line number Diff line change
@@ -488,8 +488,8 @@ Optional<HTMLToken> HTMLTokenizer::next_token(StopAtInsertionPoint stop_at_inser
}
ON_EOF
{
m_queued_tokens.enqueue(move(m_current_token));
EMIT_EOF;
m_current_token.set_comment(consume_current_builder());
EMIT_CURRENT_TOKEN_FOLLOWED_BY_EOF;
}
ON(0)
{
Original file line number Diff line number Diff line change
@@ -2,8 +2,7 @@ Harness status: OK

Found 16 tests

15 Pass
1 Fail
16 Pass
Pass html5lib_comments01.html 3dbda8330033c3fbf3185a55e963075328099578
Pass html5lib_comments01.html 7476098e9823b3deee1857739daf719ff18e37b4
Pass html5lib_comments01.html eca7f97a4659eab6da4127c225420f1664b6c0c4
@@ -17,6 +16,6 @@ Pass html5lib_comments01.html 8b36d140a4a223b083a8d41af7c98a1c20377856
Pass html5lib_comments01.html 1894e23c5ee89d6f4b5f1dbe9b681b42863b4d1f
Pass html5lib_comments01.html 2cefeae994b6b0be0accbfff4757fef40ed914eb
Pass html5lib_comments01.html ac9fd94008255e73cba953dbd374cb41703f5446
Fail html5lib_comments01.html 617815b6a683613fcb6b9cd5841b2ea7428d838d
Pass html5lib_comments01.html 617815b6a683613fcb6b9cd5841b2ea7428d838d
Pass html5lib_comments01.html bb8faf75d2e28aee13ec4a0d8eab00b4d7475763
Pass html5lib_comments01.html 89c4ae1ae34df9dff0e516afdef87cd169c3e6a5