-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LibCrypto+LibWeb: Support P-521 with OpenSSL #3374
Conversation
The code was printing one error message only, but multiple can be generated in one call. Additionally, using this builtin produces a much more descriptive output.
4be180b
to
2581924
Compare
I took a brief look, the only issue I noticed was addressed in the last commit so 👍 |
Ah yes,
|
I love it when it's so descriptive lol. Anyway, I think it's a memory leak problem again, I am building with sanitizers locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks largely OK, there's some signed len functions that could maybe have better names for the return values though:
Our `UnsignedBigInteger` implementation cannot handle numbers whose size is not a multiple of 4. For this reason we need to carry the real size around for P-521 support.
Indeed, I was not freeing instances of |
This PR introduces P-521 support by rewriting the SECPxxxr1 implementation using OpenSSL, this should be the last remaining piece of implementation for WebCryptoAPI. After this I expect us to pass all WPT tests except ~100.