[Quest] Implement You Call That a Knife Quest #6372
Conversation
jamesbradleym
changed the title
| [28] = function(player, csid, option, npc) | ||
| player:confirmTrade() | ||
| if os.time() >= npc:getLocalVar('cooldown') then | ||
| spawnCooks(player, npc) |
There was a problem hiding this comment.
There exists a command for this in npcUtil:
npcUtil.popFromQM(player, npc, { TABLE_OF_MOD_IDS }, {claim = boolean, hide = integer}) etc. etc.
| if npcUtil.tradeHasExactly(trade, { xi.item.TONBERRY_BOARD }) then | ||
| return quest:progressEvent(27) | ||
| else | ||
| npcUtil.confirmTradedItems(trade) -- Take all items traded |
There was a problem hiding this comment.
Why create a function for this? You should be able to just use player:confirmTrade()
There was a problem hiding this comment.
From my understanding player:confirmTrade() works on items that have been confirmed (such as through npcUtil.tradeHasExactly), I did not see a utility that would accept all items regardless of confirmation so I made this one.
There was a problem hiding this comment.
I'll leave that discretion with LSB mods.
| quest:complete(player) | ||
| player:delKeyItem(xi.ki.NONBERRYS_KNIFE) | ||
| quest:setMustZone(player) |
There was a problem hiding this comment.
This is a safe practice to get into. If there's an error when trying to complete the quest, the player won't lose their key item. This is more common and useful with quests that have items in their rewards
| quest:complete(player) | |
| player:delKeyItem(xi.ki.NONBERRYS_KNIFE) | |
| quest:setMustZone(player) | |
| if quest:complete(player) then | |
| player:delKeyItem(xi.ki.NONBERRYS_KNIFE) | |
| quest:setMustZone(player) | |
| end |
| xi.mix.jobSpecial.config(mob, { | ||
| specials = | ||
| { | ||
| { id = xi.jsa.ASTRAL_FLOW }, | ||
| }, | ||
| }) |
There was a problem hiding this comment.
This isn't required. It's done by loading the mixin above like you've done.
There was a problem hiding this comment.
Ahh, gotcha. Thanks for the explanation!
| xi.mix.jobSpecial.config(mob, { | ||
| specials = | ||
| { | ||
| { id = xi.jsa.MIJIN_GAKURE }, | ||
| }, | ||
| }) | ||
| end |
| end | ||
|
|
||
| local function spawnCooks(player, npc) | ||
| if not isFightInProgress() then |
There was a problem hiding this comment.
popFromQM makes this check
There was a problem hiding this comment.
I got distracted by the QM part 😅
Appreciate the review here! Removed the other bits as they're no longer necessary
There was a problem hiding this comment.
Awesome! Thanks for the quick responses here.
jamesbradleym
force-pushed
the
You-Call-That-a-Knife
branch
3 times, most recently
from
a6ca7d0 to
af73a26
Compare
jamesbradleym
force-pushed
the
You-Call-That-a-Knife
branch
from
af73a26 to
d7b0abd
Compare
I affirm:
What does this pull request do?
Implements quest
You Call That a Knife?Steps to test these changes
Setup:
Pre-Requisites:
Quest:
SandfishtoMhebi Juhbily(!pos 40 -11 -159 250)Shedto trigger CS withMhebi Juhbily-- Quest StartVah Keshura(!pos 30 -8.5 -105 250)Tonberry BoardtoChef Nonberry(!additem 1145) (!pos -136 0.0 -91 159)Mhebi Juhbilywith Key ItemNonberry's Knife-- Quest CompleteNotes:
Chef Nonberry, you can trade the correct item at any time to get the Key ItemSheddoes not seem to have a post quest + zone eventMehbi Juhbilypost quest and zoneCapture