[lua, quest] Converts BRD unlock and BRD AF1 to IF

[CriticalXI]

I affirm:

• I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
• I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
• I have read and understood the Contributing Guide and the Code of Conduct.
• I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

• Converts Path of the Bard and Painful Memory BRD quests to interaction framework

Path of the Bard: https://www.youtube.com/watch?v=ZAJAjoMJFdo
Painful Memory: https://www.youtube.com/watch?v=QXsns9eag10

Steps to test these changes

• Complete A Minstrel in Despair quest either manually or through GM commands
• Speak with Song Runes in Valkurm Dunes to complete Path of the Bard quest
• Set yourself to BRD 40 to start Painful Memory quest and follow the quest steps

[Xaver-DaRed]

onTrigger = function(player, npc)
    local initialCS = quest:getVar(player, 'initialCS')
    if initialCS == 0 then
        return quest:progressEvent(138)
    elseif initialCS == 1 then
        return quest:progressEvent(137)
    end
end,

[CriticalXI]

Adjusted to the example

[Xaver-DaRed]

Theres only 1 condition here. Also, as above, store the variable in a local var instead of fetching it.

[slashtangent]

As written, there is a bug with this part of the code. If the player delays checking the Waters of Oblivion until after Tros has fully despawned, Tros will then respawn and agro onto the player while they are in the final cutscene.

if
    nmKilled == 0 and
    player:hasKeyItem(xi.ki.MERTAIRES_BRACELET) and
    npcUtil.popFromQM(player, npc, ID.mob.TROS, { claim = true, hide = 0 })
then

Swap the NM killed check to the top (or at least above the NM spawn) to prevent this from happening. Since you want to make sure all checks are passed before spawning the NM.

[CriticalXI]

Good point, I'll keep that in mind for future quests. Got it adjusted, along with the NPC commands below.

[slashtangent]

Swap these !gotoid checks to !pos this way if ids ever shift this won't cause issues or need to be updated in the future.

[slashtangent]

This !gotoid as well.