Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sql] add content tag to COP era recipes #6866

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

Grahf0085
Copy link
Contributor

@Grahf0085 Grahf0085 commented Jan 27, 2025

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Adds content tags for synthesis recipes for the remaining recipes added during COP. Recipes were round by search through the update history before April of 2006 here: http://ffxi.somepage.com/news/highlights.php#Patch_Info

Steps to test these changes

Run dbtool

@Grahf0085 Grahf0085 changed the title add content tag to COP era recipes [sql] add content tag to COP era recipes Jan 27, 2025
@Frankie-hz
Copy link
Contributor

In the future please submit a little less than 200+ entries at once. It takes a very long time to review for accuracy. If you submit 30/50 a PR it can get merged much faster. Trying to find time to review 226 recipes is very time consuming

@Grahf0085
Copy link
Contributor Author

In the future please submit a little less than 200+ entries at once. It takes a very long time to review for accuracy. If you submit 30/50 a PR it can get merged much faster. Trying to find time to review 226 recipes is very time consuming

Sorry boss. If it helps I can either break this PR up into smaller PRs or add comments to each line with a link to where I got the info. Thanks for reviewing......

@Grahf0085 Grahf0085 closed this Jan 29, 2025
@Grahf0085
Copy link
Contributor Author

......I didn't mean to close this

@Grahf0085 Grahf0085 reopened this Jan 29, 2025
INSERT INTO `synth_recipes` VALUES (14580,0,0,0,97,0,0,0,0,0,0,4096,4238,1466,1466,0,0,0,0,0,0,1467,1467,1467,1467,1,1,1,1,'Relic Steel',NULL);
INSERT INTO `synth_recipes` VALUES (14581,0,0,0,97,0,0,0,0,0,0,4096,4238,1286,16423,0,0,0,0,0,0,18361,18361,18361,18361,1,1,1,1,'Ponder. Manoples',NULL);
INSERT INTO `synth_recipes` VALUES (14581,0,0,0,97,0,0,0,0,0,0,4096,4238,1286,16423,0,0,0,0,0,0,18361,18361,18361,18361,1,1,1,1,'Ponderous Manoples','COP');
Copy link
Contributor

@Frankie-hz Frankie-hz Feb 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This goes for all the Ponderous weapons: Everything says 2006, including comments on alakazam. It is so weird the only website that has oct 2005 is somepage. I cant find a single reference to 2005 other than this singular page.

Edit: I asked around and a few said CoP and I am inclined to say CoP as well. Everything else looks good though,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah lots of conflicting info out there.

@claywar claywar merged commit 865082c into LandSandBoat:base Feb 4, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants