Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Interaction] Rewrite "An explorers Footsteps" #6873

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

Xaver-DaRed
Copy link
Contributor

@Xaver-DaRed Xaver-DaRed commented Jan 28, 2025

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Rewrites "An explorers Footsteps" quest.

  • Recaptured it.
  • Simplified logic.
  • Corrected behavior when you choose not to continue the quest.
  • Corrected invalid parameter values being fed, resulting in empty/blank options.
  • Corrected order of zones.
  • Corrected requested zone selection (just follow the list in order).

Closes #6835

Steps to test these changes

Run the quest

@Xaver-DaRed Xaver-DaRed force-pushed the clay branch 3 times, most recently from 40e26c2 to a418f42 Compare January 28, 2025 03:43
@Xaver-DaRed Xaver-DaRed marked this pull request as ready for review January 28, 2025 03:53
@Grahf0085
Copy link
Contributor

Grahf0085 commented Jan 28, 2025

Throwing out the clay right after accepting the quest breaks it.

Edit: you have to zone after dropping the clay to get a new one

@zach2good zach2good merged commit 3c5090d into LandSandBoat:base Jan 28, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants