Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Sky cermet doors opening on click when they shouldnt #7061

Merged
merged 2 commits into from
Feb 17, 2025

Conversation

Xaver-DaRed
Copy link
Contributor

@Xaver-DaRed Xaver-DaRed commented Feb 17, 2025

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Doors that arent supposed to open on click need either:

  • An empty script with an empty onTrigger function.
  • An entry in default actions.
  • An entry in an IF script.

Steps to test these changes

Go to sky. It still sucks.

Copy link
Contributor

@KnowOne134 KnowOne134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3rd option is to add to an if page also

@Xaver-DaRed
Copy link
Contributor Author

I toyed a little more with this and found a way not to create the scripts. Claywar's work is safe^^

@claywar claywar merged commit 6cf5475 into LandSandBoat:base Feb 17, 2025
13 checks passed
@Xaver-DaRed Xaver-DaRed deleted the not-the-door branch February 17, 2025 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants