Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] QM2 not moving around zone properly #7068

Open
wants to merge 2 commits into
base: base
Choose a base branch
from

Conversation

Eggowaffle1288
Copy link
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

The QM that spawns Mokkurkalfi was not moving around the zone every 15mins like it should

would always default to table pos 1.
issue with npcUtil.pickNewPosition, passing true to the function seems to not allow it to move? setting it to false generates a new position.
Since this should move every 15 mins real time (1hour = 2.4mins 15mins ish = 6 hours), it doesnt make sense to move the QM every time the ontrigger happens? so i moved the logic to the Ro'Maeve zone file.

Steps to test these changes

use gm command !addmission 1 12
talk to Cid
go to Ro'Maeve, QM will now move from spot to spot like it should every 15 mins real time

vanadielHour == 12 or
vanadielHour == 18
then
npcUtil.queueMove(qm2, newPosition)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think LLS CI is complaining that qm2 isn't nil checked

try adding an if qm2 then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants