Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Synthesis] Separate both craft failing types #7071

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

Xaver-DaRed
Copy link
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

The purpose of this PR is to avoid setting a modifier on the character and making unnecesary calculations when all materials are going to be broken anyway. It also removes the need of a bool parameter and the need to choose between messages.

Steps to test these changes

Craft. Fail. Craft in MH, DC inside, loose everything

Avoid toying with modifiers and making calculations when unneeded
@zach2good zach2good merged commit 83c4c87 into LandSandBoat:base Feb 18, 2025
14 checks passed
@Xaver-DaRed Xaver-DaRed deleted the fail branch February 20, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants