Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Add Sol bindings for CLuaLootContainer class #7079

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

bope12
Copy link
Contributor

@bope12 bope12 commented Feb 18, 2025

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Currently Listener "ITEM_DROPS" is unable to be used as the the second arg that is suppose to be the LootContainer is not being converted resulting in the error "attempt to index local 'loot' (a userdata value)"
This PR re adds the sol binding for LootContainer to CLuaLootContainer

Steps to test these changes

Add a Listener "ITEM_DROPS" to a mob
Kill mob
No error in the script and items added via the listener can be rolled

@zach2good zach2good merged commit bc1c0d4 into LandSandBoat:base Feb 18, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants