Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Set m_TimeType at server startup, call TOTD change on startup #7083

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

WinterSolstice8
Copy link
Member

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

m_TimeType is not set on startup which could cause issues with mob scripts that check TOTD.
Call TOTD change on startup so mobs that should spawn at certain times do (such as undead)
Note: time_server is normally what calls that, but it's delayed by 2.4 seconds so as far as I know this wouldn't result in TOTD change being called twice with the same time type.

Steps to test these changes

start server @ night
!zone konschtat highlands
!gotoname Wolf_Zombie 1

See zombie there

@WinterSolstice8 WinterSolstice8 force-pushed the TOTD_stuff branch 2 times, most recently from 67e9b63 to 24ed5b4 Compare February 18, 2025 19:18
@zach2good zach2good merged commit 8d3f120 into LandSandBoat:base Feb 19, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants