Skip to content

Commit

Permalink
Add focusable=false to svgs
Browse files Browse the repository at this point in the history
  • Loading branch information
moroshko committed Jan 30, 2020
1 parent 66f75c6 commit bdb73ca
Show file tree
Hide file tree
Showing 43 changed files with 48 additions and 1 deletion.
7 changes: 6 additions & 1 deletion src/components/Checkbox.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,12 @@ function CheckboxIcon({ color, isChecked }) {
const theme = useTheme();

return (
<svg css={theme.checkboxIcon} viewBox="0 0 100 100" aria-hidden="true">
<svg
css={theme.checkboxIcon}
viewBox="0 0 100 100"
focusable="false"
aria-hidden="true"
>
<rect
css={theme[`checkboxIcon.${color}`]}
width="100"
Expand Down
1 change: 1 addition & 0 deletions src/components/LoadingIcon.js
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,7 @@ function LoadingIcon(_props) {
width={svgSize}
height={svgSize}
viewBox={`0 0 ${svgSize} ${svgSize}`}
focusable="false"
role="img"
aria-label="Loading icon"
data-testid={testId}
Expand Down
1 change: 1 addition & 0 deletions src/components/RadioGroup.js
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ function RadioCircle({ color, isChecked }) {
<svg
css={theme.radioGroupRadioCircle}
viewBox="0 0 24 24"
focusable="false"
aria-hidden="true"
>
<circle
Expand Down
1 change: 1 addition & 0 deletions src/icons/arrow-back.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ function ArrowBack({ primaryColor, testId }) {
width={32}
height={32}
viewBox="0 0 32 32"
focusable="false"
role="img"
aria-label="Arrow back"
data-testid={testId}
Expand Down
1 change: 1 addition & 0 deletions src/icons/arrow-forward.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ function ArrowForward({ primaryColor, testId }) {
width={32}
height={32}
viewBox="0 0 32 32"
focusable="false"
role="img"
aria-label="Arrow forward"
data-testid={testId}
Expand Down
1 change: 1 addition & 0 deletions src/icons/birthday.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ function Birthday({ primaryColor, testId }) {
width={32}
height={32}
viewBox="0 0 32 32"
focusable="false"
role="img"
aria-label="Birthday"
data-testid={testId}
Expand Down
1 change: 1 addition & 0 deletions src/icons/calculator.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ function Calculator({ primaryColor, testId }) {
width="32"
height="32"
viewBox="0 0 32 32"
focusable="false"
role="img"
aria-label="Calculator"
data-testid={testId}
Expand Down
1 change: 1 addition & 0 deletions src/icons/chevron-down.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ function ChevronDown({ primaryColor, testId }) {
width={32}
height={32}
viewBox="0 0 32 32"
focusable="false"
role="img"
aria-label="Chevron down"
data-testid={testId}
Expand Down
1 change: 1 addition & 0 deletions src/icons/chevron-left.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ function ChevronLeft({ primaryColor, testId }) {
width={32}
height={32}
viewBox="0 0 32 32"
focusable="false"
role="img"
aria-label="Chevron left"
data-testid={testId}
Expand Down
1 change: 1 addition & 0 deletions src/icons/chevron-right.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ function ChevronRight({ primaryColor, testId }) {
width={32}
height={32}
viewBox="0 0 32 32"
focusable="false"
role="img"
aria-label="Chevron right"
data-testid={testId}
Expand Down
1 change: 1 addition & 0 deletions src/icons/chevron-up.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ function ChevronUp({ primaryColor, testId }) {
width={32}
height={32}
viewBox="0 0 32 32"
focusable="false"
role="img"
aria-label="Chevron up"
data-testid={testId}
Expand Down
1 change: 1 addition & 0 deletions src/icons/comparison.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ function Comparison({ primaryColor, testId }) {
width={32}
height={32}
viewBox="0 0 32 32"
focusable="false"
role="img"
aria-label="Comparison"
data-testid={testId}
Expand Down
1 change: 1 addition & 0 deletions src/icons/cross-small.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ function CrossSmall({ primaryColor, testId }) {
width={32}
height={32}
viewBox="0 0 32 32"
focusable="false"
role="img"
aria-label="Cross small"
data-testid={testId}
Expand Down
1 change: 1 addition & 0 deletions src/icons/cross.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ function Cross({ primaryColor, testId }) {
width={32}
height={32}
viewBox="0 0 32 32"
focusable="false"
role="img"
aria-label="Cross"
data-testid={testId}
Expand Down
1 change: 1 addition & 0 deletions src/icons/download.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ function Download({ primaryColor, testId }) {
width={32}
height={32}
viewBox="0 0 32 32"
focusable="false"
role="img"
aria-label="Download"
data-testid={testId}
Expand Down
1 change: 1 addition & 0 deletions src/icons/edit.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ function Edit({ primaryColor, testId }) {
width={32}
height={32}
viewBox="0 0 32 32"
focusable="false"
role="img"
aria-label="Edit"
data-testid={testId}
Expand Down
1 change: 1 addition & 0 deletions src/icons/external-link.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ function ExternalLink({ primaryColor, testId }) {
width={32}
height={32}
viewBox="0 0 32 32"
focusable="false"
role="img"
aria-label="External link"
data-testid={testId}
Expand Down
1 change: 1 addition & 0 deletions src/icons/eye-hidden.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ function EyeHidden({ primaryColor, testId }) {
width={32}
height={32}
viewBox="0 0 32 32"
focusable="false"
role="img"
aria-label="Eye hidden"
data-testid={testId}
Expand Down
1 change: 1 addition & 0 deletions src/icons/eye-visible.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ function EyeVisible({ primaryColor, testId }) {
width={32}
height={32}
viewBox="0 0 32 32"
focusable="false"
role="img"
aria-label="Eye visible"
data-testid={testId}
Expand Down
1 change: 1 addition & 0 deletions src/icons/face-id.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ function FaceID({ primaryColor, testId }) {
width={32}
height={32}
viewBox="0 0 32 32"
focusable="false"
role="img"
aria-label="Face ID"
data-testid={testId}
Expand Down
1 change: 1 addition & 0 deletions src/icons/fingerprint.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ function Fingerprint({ primaryColor, testId }) {
width={32}
height={32}
viewBox="0 0 32 32"
focusable="false"
role="img"
aria-label="Fingerprint"
data-testid={testId}
Expand Down
1 change: 1 addition & 0 deletions src/icons/hamburger.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ function Hamburger({ primaryColor, testId }) {
width={32}
height={32}
viewBox="0 0 32 32"
focusable="false"
role="img"
aria-label="Hamburger"
data-testid={testId}
Expand Down
1 change: 1 addition & 0 deletions src/icons/lock-small.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ function LockSmall({ primaryColor, testId }) {
width={32}
height={32}
viewBox="0 0 32 32"
focusable="false"
role="img"
aria-label="Lock small"
data-testid={testId}
Expand Down
1 change: 1 addition & 0 deletions src/icons/lock.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ function Lock({ primaryColor, testId }) {
width={32}
height={32}
viewBox="0 0 32 32"
focusable="false"
role="img"
aria-label="Lock"
data-testid={testId}
Expand Down
1 change: 1 addition & 0 deletions src/icons/mail.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ function Mail({ primaryColor, testId }) {
width={32}
height={32}
viewBox="0 0 32 32"
focusable="false"
role="img"
aria-label="Mail"
data-testid={testId}
Expand Down
1 change: 1 addition & 0 deletions src/icons/message.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ function Message({ primaryColor, testId }) {
width={32}
height={32}
viewBox="0 0 32 32"
focusable="false"
role="img"
aria-label="Message"
data-testid={testId}
Expand Down
1 change: 1 addition & 0 deletions src/icons/notification-new.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ function NotificationNew({ primaryColor, secondaryColor, testId }) {
width={32}
height={32}
viewBox="0 0 32 32"
focusable="false"
role="img"
aria-label="Notification new"
data-testid={testId}
Expand Down
1 change: 1 addition & 0 deletions src/icons/notification.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ function Notification({ primaryColor, testId }) {
width={32}
height={32}
viewBox="0 0 32 32"
focusable="false"
role="img"
aria-label="Notification"
data-testid={testId}
Expand Down
1 change: 1 addition & 0 deletions src/icons/overflow-menu.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ function OverflowMenu({ primaryColor, testId }) {
width={32}
height={32}
viewBox="0 0 32 32"
focusable="false"
role="img"
aria-label="Overflow menu"
data-testid={testId}
Expand Down
1 change: 1 addition & 0 deletions src/icons/person.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ function Person({ primaryColor, testId }) {
width={32}
height={32}
viewBox="0 0 32 32"
focusable="false"
role="img"
aria-label="Person"
data-testid={testId}
Expand Down
1 change: 1 addition & 0 deletions src/icons/question.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ function Question({ primaryColor, testId }) {
width={32}
height={32}
viewBox="0 0 32 32"
focusable="false"
role="img"
aria-label="Question"
data-testid={testId}
Expand Down
1 change: 1 addition & 0 deletions src/icons/search.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ function Search({ primaryColor, testId }) {
width={32}
height={32}
viewBox="0 0 32 32"
focusable="false"
role="img"
aria-label="Search"
data-testid={testId}
Expand Down
1 change: 1 addition & 0 deletions src/icons/shield.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ function Shield({ primaryColor, testId }) {
width={32}
height={32}
viewBox="0 0 32 32"
focusable="false"
role="img"
aria-label="Shield"
data-testid={testId}
Expand Down
1 change: 1 addition & 0 deletions src/icons/stopwatch-alt.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ function StopwatchAlt({ primaryColor, testId }) {
width={32}
height={32}
viewBox="0 0 32 32"
focusable="false"
role="img"
aria-label="Stopwatch alt"
data-testid={testId}
Expand Down
1 change: 1 addition & 0 deletions src/icons/stopwatch.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ function Stopwatch({ primaryColor, testId }) {
width={32}
height={32}
viewBox="0 0 32 32"
focusable="false"
role="img"
aria-label="Stopwatch"
data-testid={testId}
Expand Down
1 change: 1 addition & 0 deletions src/icons/tick-small.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ function TickSmall({ primaryColor, testId }) {
width={32}
height={32}
viewBox="0 0 32 32"
focusable="false"
role="img"
aria-label="Tick small"
data-testid={testId}
Expand Down
1 change: 1 addition & 0 deletions src/icons/tick.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ function Tick({ primaryColor, testId }) {
width={32}
height={32}
viewBox="0 0 32 32"
focusable="false"
role="img"
aria-label="Tick"
data-testid={testId}
Expand Down
1 change: 1 addition & 0 deletions src/icons/time.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ function Time({ primaryColor, testId }) {
width={32}
height={32}
viewBox="0 0 32 32"
focusable="false"
role="img"
aria-label="Time"
data-testid={testId}
Expand Down
1 change: 1 addition & 0 deletions src/icons/triangle-down.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ function TriangleDown({ primaryColor, testId }) {
width={32}
height={32}
viewBox="0 0 32 32"
focusable="false"
role="img"
aria-label="Triangle down"
data-testid={testId}
Expand Down
1 change: 1 addition & 0 deletions src/icons/triangle-up.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ function TriangleUp({ primaryColor, testId }) {
width={32}
height={32}
viewBox="0 0 32 32"
focusable="false"
role="img"
aria-label="Triangle up"
data-testid={testId}
Expand Down
1 change: 1 addition & 0 deletions src/logos/gem.js
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ function GemLogo(_props) {
...responsivePropsCSS
}}
viewBox="0 0 548.23 233.65"
focusable="false"
role="img"
aria-label="Gem by Latitude logo"
data-testid={testId}
Expand Down
1 change: 1 addition & 0 deletions src/logos/latitude.js
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ function LatitudeLogo(_props) {
...responsivePropsCSS
}}
viewBox="0 0 197 32"
focusable="false"
role="img"
aria-label="Latitude logo"
data-testid={testId}
Expand Down
1 change: 1 addition & 0 deletions website/src/components/icons/inspect.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ function InspectIcon(props) {
width={24}
height={24}
viewBox="0 0 32 32"
focusable="false"
role="img"
aria-label="Inspect components"
fill={color}
Expand Down

0 comments on commit bdb73ca

Please sign in to comment.