Adding some events and handler #225
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @jjti ,
I added some features to SeqViz to increase the ability to control events triggered from elements like bases, translations and annotations where you can pass onClick, onDoubleClick, onContextMenu and onHover, then you can check the type of element and do some action. I added some example how we can use these handlers.
I also added onKeyPress event handler if developer wants to set some custom keyboard shortcuts.
I think onHover event handler will help to display more details about elements.
onContextMenu and onKeyPress will be useful to build SeqViz editor not only a viewer.
Please review my changes and give me your opinion.
I am waiting to hear from you.
Thank you to consider my pull request.
@Eng-Elias