-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
T6 SndBank & SndDriverGlobals Asset Dumping #58
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your work :) I didn't manage to look through the SndBank code fully yet, the comments should just be minor stuff
src/ObjWriting/Game/T6/AssetDumpers/AssetDumperSndDriverGlobals.cpp
Outdated
Show resolved
Hide resolved
src/ObjWriting/Game/T6/AssetDumpers/AssetDumperSndDriverGlobals.cpp
Outdated
Show resolved
Hide resolved
src/ObjWriting/Game/T6/AssetDumpers/AssetDumperSndDriverGlobals.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a small fix then should be ready :)
Finish dumping the SndBank asset's relevant pieces as well as SndDriverGlobals
The sound driver globals are necessary to dump the SndAlias flags back into the split out columns as well as the duck group & curve group names. Ideally instead of hardcoding these values we should reference the single global SndDriverGlobals asset but I'm not sure if that's necesarry as it is unlikely anyone will want to modify that asset type