T6 SndBank & SndDriverGlobals Asset Dumping #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Laupetin
reviewed
Dec 12, 2023
src/ObjWriting/Game/T6/AssetDumpers/AssetDumperSndDriverGlobals.cpp
Outdated
Show resolved
Hide resolved
src/ObjWriting/Game/T6/AssetDumpers/AssetDumperSndDriverGlobals.cpp
Outdated
Show resolved
Hide resolved
src/ObjWriting/Game/T6/AssetDumpers/AssetDumperSndDriverGlobals.cpp
Outdated
Show resolved
Hide resolved
Laupetin
reviewed
Dec 21, 2023
added 2 commits
December 27, 2023 23:05
Laupetin
reviewed
Jan 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finish dumping the SndBank asset's relevant pieces as well as SndDriverGlobals
The sound driver globals are necessary to dump the SndAlias flags back into the split out columns as well as the duck group & curve group names. Ideally instead of hardcoding these values we should reference the single global SndDriverGlobals asset but I'm not sure if that's necesarry as it is unlikely anyone will want to modify that asset type