[T6] - SndBank Linking and Sound Bank (.sabs/.sabl) Writing #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skiff
changed the title
|
I think there may be an issue somewhere still with truly custom sounds. Need to investigate |
|
Fixed the issues with fully custom sounds. Custom sabl and sabs files are loading correctly now |
Laupetin
reviewed
Feb 8, 2024
|
Thanks for making this feature :) The CSV Reader for headers definitely is a good addition. Also nice branding section 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #26
Properly link SndBank assets for T6. This includes generating the appropriate sound bank file needed for loaded and streamed sounds. Supports linking the sound aliases, sound reverbs and sound ducks.
Note: The Sound Bank files have a checksum in them that is supposed to be an MD5 hash of the data section. However, the game does not validate this in any way. All that is checked is that the same checksum exists in the actual SndBank asset. Since T6 is the only supported game that uses sound bank files, it is not necessary to calculate this and instead the SndBank asset and Sound Bank file are populated with default ('\xCC') data for the checksum. If other games are added in the future that utilize the Sound Bank files, this may need to be corrected