Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[T6] - SndBank Linking and Sound Bank (.sabs/.sabl) Writing #99

Merged
merged 27 commits into from
Feb 11, 2024

Conversation

skiff
Copy link
Contributor

@skiff skiff commented Jan 26, 2024

Issue: #26

Properly link SndBank assets for T6. This includes generating the appropriate sound bank file needed for loaded and streamed sounds. Supports linking the sound aliases, sound reverbs and sound ducks.

Note: The Sound Bank files have a checksum in them that is supposed to be an MD5 hash of the data section. However, the game does not validate this in any way. All that is checked is that the same checksum exists in the actual SndBank asset. Since T6 is the only supported game that uses sound bank files, it is not necessary to calculate this and instead the SndBank asset and Sound Bank file are populated with default ('\xCC') data for the checksum. If other games are added in the future that utilize the Sound Bank files, this may need to be corrected

@skiff skiff changed the title [T6] - SndBank Linking and Sound Bank (.sabs/.sabl) Writing #26 [T6] - SndBank Linking and Sound Bank (.sabs/.sabl) Writing Jan 26, 2024
@skiff skiff marked this pull request as draft February 2, 2024 16:58
@skiff
Copy link
Contributor Author

skiff commented Feb 2, 2024

I think there may be an issue somewhere still with truly custom sounds. Need to investigate

@skiff skiff marked this pull request as ready for review February 2, 2024 22:03
@skiff
Copy link
Contributor Author

skiff commented Feb 2, 2024

Fixed the issues with fully custom sounds. Custom sabl and sabs files are loading correctly now

src/Crypto/Impl/AlgorithmMD5.h Outdated Show resolved Hide resolved
src/ObjWriting/Sound/WavWriter.h Outdated Show resolved Hide resolved
src/Utils/Utils/StringUtils.cpp Outdated Show resolved Hide resolved
src/Utils/Utils/StringUtils.cpp Outdated Show resolved Hide resolved
src/ObjCommon/Game/T6/ObjConstantsT6.h Outdated Show resolved Hide resolved
src/ObjCommon/Csv/ParsedCsv.cpp Outdated Show resolved Hide resolved
src/ObjCommon/Csv/ParsedCsv.h Outdated Show resolved Hide resolved
src/ObjLoading/ObjContainer/SoundBank/SoundBankWriter.cpp Outdated Show resolved Hide resolved
src/ObjLoading/ObjContainer/SoundBank/SoundBankWriter.cpp Outdated Show resolved Hide resolved
@Laupetin
Copy link
Owner

Laupetin commented Feb 8, 2024

Thanks for making this feature :) The CSV Reader for headers definitely is a good addition. Also nice branding section 😄

@skiff skiff requested a review from Laupetin February 9, 2024 20:11
@Laupetin Laupetin merged commit b741fe3 into Laupetin:main Feb 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants