Skip to content

Commit

Permalink
Clarified the checklist for self-review (#2167)
Browse files Browse the repository at this point in the history
* Clarified the checklist for self-review

So that there are fewer contradictions between the points.

* Update icon_checklist.md
  • Loading branch information
x9136 authored Jun 17, 2024
1 parent 7f928e6 commit 1496be2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/icon_checklist.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ Example: `京东 ~~ JD`.

### Quality
1. Ensure that icons are easily recognizable.
2. Align icons to [the visual center](https://www.google.com/search?sca_esv=1fcec3f5e0b15e20&q=what+is+visual+center+of+an+icon&tbm=isch&source=lnms).
2. Align icons to [the visual center](https://www.google.com/search?sca_esv=1fcec3f5e0b15e20&q=what+is+visual+center+of+an+icon&tbm=isch&source=lnms) as much as possible within the guidelines.
3. Avoid noticable black spots by reducing the stroke width or simplifying the icons.
4. Avoid close distances between strokes. The icons on the phone screen will be smaller, so the small distances between the strokes will stick together.
5. Avoid drastic changes in stroke widths. When the strokes next to each other differ in width by 4px or more, the icon will look sloppy.

0 comments on commit 1496be2

Please sign in to comment.