Integrate with eigensdk wallet #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-shim
commented
Mar 14, 2024
samlaf
reviewed
Mar 15, 2024
samlaf
approved these changes
Mar 18, 2024
| if err != nil { | ||
| return fmt.Errorf("Cannot get sender address: %w", err) | ||
| } | ||
| logger.Infof("Sender address: %s", sender.Hex()) |
There was a problem hiding this comment.
Is this needed, or was this only used for debugging?
Or should this be at the debug level?
There was a problem hiding this comment.
I left it at info level because it seemed useful enough and it's logged only once at initialization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates EigenSDK wallet so that transactions can be sent using either a EOA with a private key or a Fireblocks MPC wallet.
It should be updated to identify correct sender and locally tested after Layr-Labs/eigensdk-go#154 is merged.