Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use eigensdk Slogger and add default env vars #21

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Use eigensdk Slogger and add default env vars #21

merged 1 commit into from
Mar 19, 2024

Conversation

ian-shim
Copy link
Contributor

slogger supports more functionality than zaplogger
also, adds missing environment variables in .env.example

@ian-shim ian-shim requested a review from samlaf March 18, 2024 16:42
@ian-shim ian-shim marked this pull request as ready for review March 18, 2024 16:43
samlaf
samlaf approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@samlaf samlaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ian-shim ian-shim merged commit 32b567f into master Mar 19, 2024
1 check passed
@ian-shim ian-shim deleted the use-slogger branch March 19, 2024 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samlaf samlaf samlaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ian-shim @samlaf