Skip to content

Commit

Permalink
docs: add comment with TODO for refactoring global init() starting te…
Browse files Browse the repository at this point in the history
…st containers
  • Loading branch information
samlaf committed Oct 16, 2024
1 parent bbd81b0 commit a9ae57b
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions e2e/setup.go
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,10 @@ var (
redisEndpoint = ""
)

// TODO: we shouldn't start the containers in the init function like this.
// Need to find a better way to start the containers and set the endpoints.
// Even better would be for the endpoints not to be global variables injected into the test configs.
// Starting the containers on init like this also makes it harder to import this file into other tests.
func init() {
err := startMinIOContainer()
if err != nil {
Expand Down

0 comments on commit a9ae57b

Please sign in to comment.