Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't allow to configure fallback or cache with nil Redis|S3 ins… #155

Merged
merged 2 commits into from
Oct 1, 2024
Merged

fix: don't allow to configure fallback or cache with nil Redis|S3 ins… #155

merged 2 commits into from
Oct 1, 2024

Conversation

mcortesi
Copy link
Contributor

To avoid user confussion, check that variables are not nil before adding them to potential sources.

If not, they will when we actually try to use them

This is because populateTargets() accepts redis and s3 variables to be nil.

samlaf
samlaf reviewed Sep 27, 2024
View reviewed changes
Copy link
Collaborator

@samlaf samlaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but @epociask is the codeowner for this feature.

epociask
epociask approved these changes Sep 28, 2024
View reviewed changes
Copy link
Collaborator

@epociask epociask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a good callout, thanks for catching :)

@samlaf samlaf merged commit 24c4715 into Layr-Labs:main Oct 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samlaf samlaf samlaf left review comments

@epociask epociask epociask approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcortesi @samlaf @epociask