Add query param to GET and PUT for commitment interpretation type #37

teddyknox · 2024-06-10T15:31:18Z

Creates type system for commitments complete with literals, Marshal() and Unmarshal() functions, and more. Hopefully allows us to encode the various commitment types such that we cannot make mistakes when using this type system (only when designing it).
Uses this type system to define a "default" commitment type which is useful for allowing the caller to define any prefix bytes that should prepended after puts and L-trimmed before gets.
Unifies the eigenda and server packages to deal with a cyclic dependency between the two.

server/server.go

commitments/op_commitment.go

server/server.go

commitments/da_service_op_commitment.go

commitments/eigenda_commitment.go

server/commitment_type.go

test/e2e_test.go

server/memory_store.go

epociask

just a few comments - mostly knits

.gitignore

client/client.go

commitments/op_commitment.go

e2e/setup.go

server/domain_type.go

verify/verify_test.go

server/server.go

server/memory_store_test.go

epociask

LGTM 💯 🚀 🚢

teddyknox requested review from epociask and afkbyte June 10, 2024 15:31

teddyknox force-pushed the add-cli-param-for-commitment-interpretation-type branch 2 times, most recently from 4f6412f to d50a6a8 Compare June 10, 2024 17:07

epociask reviewed Jun 10, 2024

View reviewed changes

teddyknox force-pushed the add-cli-param-for-commitment-interpretation-type branch 2 times, most recently from e350a62 to 2e91bb2 Compare June 10, 2024 18:41

teddyknox requested a review from epociask June 10, 2024 19:23

epociask reviewed Jun 10, 2024

View reviewed changes

test/e2e_test.go Outdated Show resolved Hide resolved

server/memory_store.go Show resolved Hide resolved

teddyknox force-pushed the add-cli-param-for-commitment-interpretation-type branch 2 times, most recently from c88e1b4 to 42dd264 Compare June 14, 2024 01:14

teddyknox requested a review from epociask June 14, 2024 01:15

teddyknox force-pushed the add-cli-param-for-commitment-interpretation-type branch from 42dd264 to 3277de9 Compare June 14, 2024 01:16

epociask reviewed Jun 14, 2024

View reviewed changes

teddyknox force-pushed the add-cli-param-for-commitment-interpretation-type branch from 9632b24 to e5f8c9e Compare June 21, 2024 00:34

teddyknox requested a review from epociask June 21, 2024 02:16

teddyknox force-pushed the add-cli-param-for-commitment-interpretation-type branch 5 times, most recently from ac4b909 to 71ad4b4 Compare June 26, 2024 14:27

Add commitment mode parameter and commitment type system

00c1401

teddyknox force-pushed the add-cli-param-for-commitment-interpretation-type branch from 71ad4b4 to 00c1401 Compare June 26, 2024 22:57

epociask approved these changes Jun 27, 2024

View reviewed changes

teddyknox merged commit 410d82c into main Jun 27, 2024
5 checks passed

teddyknox deleted the add-cli-param-for-commitment-interpretation-type branch June 27, 2024 02:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add query param to GET and PUT for commitment interpretation type #37

Add query param to GET and PUT for commitment interpretation type #37

teddyknox commented Jun 10, 2024 •

edited

Loading

epociask left a comment

epociask left a comment

Add query param to GET and PUT for commitment interpretation type #37

Add query param to GET and PUT for commitment interpretation type #37

Conversation

teddyknox commented Jun 10, 2024 • edited Loading

epociask left a comment

Choose a reason for hiding this comment

epociask left a comment

Choose a reason for hiding this comment

teddyknox commented Jun 10, 2024 •

edited

Loading