Type `accountID` as Address instead of string #1335

ian-shim · 2025-02-27T06:32:05Z

Why are these changes needed?

Typing accountID as Address ([20]byte) instead of string

I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
I've checked the new test coverage and the coverage percentage didn't drop.
Testing Strategy
- Unit tests
- Integration tests
- This PR is not tested :(

disperser/apiserver/disperse_blob_v2.go

ian-shim force-pushed the type-account-id branch 2 times, most recently from 9f08a84 to 275bc45 Compare February 27, 2025 17:50

ian-shim requested review from hopeyen and cody-littley and removed request for hopeyen February 27, 2025 18:03

ian-shim marked this pull request as ready for review February 27, 2025 18:03

ian-shim requested a review from anupsv February 28, 2025 00:38

hopeyen reviewed Feb 28, 2025

View reviewed changes

disperser/apiserver/disperse_blob_v2.go Show resolved Hide resolved

ian-shim added 2 commits March 3, 2025 09:31

accountID string -> Address

8f7aa48

validate account in checkPaymentMeter

e95752d

ian-shim force-pushed the type-account-id branch from 275bc45 to e95752d Compare March 3, 2025 17:34

cody-littley approved these changes Mar 3, 2025

View reviewed changes

hopeyen self-requested a review March 3, 2025 20:23

hopeyen approved these changes Mar 3, 2025

View reviewed changes

anupsv approved these changes Mar 3, 2025

View reviewed changes

ian-shim merged commit 83fcd32 into Layr-Labs:master Mar 4, 2025
10 checks passed