Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: check blob key exist before payments #1370

Merged
merged 2 commits into from
Mar 9, 2025
Merged

Conversation

hopeyen
Copy link
Contributor

@hopeyen hopeyen commented Mar 6, 2025

Why are these changes needed?

https://linear.app/eigenlabs/issue/EGDA-997/eda2-11-[medium]-lack-of-replay-protection-in-blob-authentication

As discussed in the meeting, for the replay protection, we add a check for blob key existence before payment validation, which should prevent a duplicated blob header dispersal

Checks

  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@hopeyen hopeyen force-pushed the hope/blob-key-check branch 3 times, most recently from bf5435e to b81a4a9 Compare March 7, 2025 06:18
@hopeyen hopeyen force-pushed the hope/blob-key-check branch from b81a4a9 to b760cb2 Compare March 7, 2025 06:45
@hopeyen hopeyen marked this pull request as ready for review March 7, 2025 07:01
@hopeyen hopeyen requested review from cody-littley and ian-shim March 7, 2025 15:50
@hopeyen hopeyen merged commit 4198de9 into master Mar 9, 2025
12 checks passed
@hopeyen hopeyen deleted the hope/blob-key-check branch March 9, 2025 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants