feat: add silent flag to enable piping claim data #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shrimalmadhur fixed all the feedback, the flag now works globally instead of boxed to just claims commands |
shrimalmadhur
requested changes
Oct 12, 2024
gpabst
force-pushed
the
gpabst/claim-silent-flag
branch
from
ed0163a
to
c1f7f37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a silent flag to rewards claim command to enable piping the claim data output without logs interfering.
What Changed?
Adds a new flag
--silentforeigenlayer rewards claim. Converts some printfs in the claim flow to use logger and sets an discarding logger when silent flag is active.