Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: vscode settings json #1071

Merged
merged 3 commits into from
Feb 7, 2025
Merged

chore: vscode settings json #1071

merged 3 commits into from
Feb 7, 2025

Conversation

0xrajath
Copy link
Contributor

@0xrajath 0xrajath commented Feb 7, 2025

Motivation:

  1. Add a vscode settings json that uses the forge formatter for format on save
  2. Remove husky

@0xrajath 0xrajath self-assigned this Feb 7, 2025
@0xrajath 0xrajath marked this pull request as ready for review February 7, 2025 00:52
@ypatil12
Copy link
Collaborator

ypatil12 commented Feb 7, 2025

Removing husky gets rid of conventional commits?

@0xrajath
Copy link
Contributor Author

0xrajath commented Feb 7, 2025

Removing husky gets rid of conventional commits?

We still have the commit lint in CI. Currently we no longer have a commitlint.js file in the repo so husky just keeps failing everytime I try to commit something. I believe @0xClandestine said that we can remove husky. But open to ideas.

@0xrajath 0xrajath merged commit 70302f0 into dev Feb 7, 2025
6 of 7 checks passed
@0xrajath 0xrajath deleted the rajath/vscode-settings branch February 7, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants