feat: add remote sign for attestation #59
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gajesh2007
approved these changes
Aug 30, 2024
|
PR looks great. FYI: planning to have the master branch fixed by EOW, then we can merge in this work. |
wesfloyd
reviewed
Sep 16, 2024
There was a problem hiding this comment.
Would you mind moving these changes to: https://github.com/Layr-Labs/hello-world-avs/blob/master/.env.example ?
We're trying to make the deployments more streamlined for local and holesky, so we removed .env.local
There was a problem hiding this comment.
FYI: there were a LOT of changes to index.ts. It might be easier to start with a fresh PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
Digest signing for AVS registration is not possible because the remote signer is very eth specific. will have to figure out a different way. So we will still need private key in remote mode but just for digest signing. But since this is an example we are okay.