Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixify #86

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

nixify #86

wants to merge 4 commits into from

Conversation

kayvank
Copy link
Contributor

@kayvank kayvank commented Oct 9, 2024

Add nix related artifacts to make project build in nixos

to verify:

$ nix develop
$ npm run build
$ npm run anvil
$ npm run deploy:core
$ npm run deploy:hello-world
$ npm run extract:abis

this is for issue #74

Add nix related artifacts to make project build in nixos
@stevennevins
Copy link
Collaborator

@kayvank Thanks for this PR. overall, it does lgtm. I will take a deeper look and run through the commands tomorrow am

Copy link

@eigen-vi eigen-vi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for sending this in! i've left a few comments if you'd be able to take a look

flake.nix Outdated Show resolved Hide resolved
flake.nix Outdated
eza
rust-analyzer-unwrapped

nodejs

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could this be pinned to 20.12.12? otherwise it's changing the node version for the project and modifying the package-lock.json

Copy link
Contributor Author

@kayvank kayvank Oct 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could this be pinned to 20.12.12? otherwise it's changing the node version for the project and modifying the package-lock.json

@eigen-vi Would you be OK with pinning it to node_20 which is Version: 20.15.1, see nix-package-search
This node version still changes some package versions in the package-lock.json, but not as drastically as before.

To pin to that specific version, I'll have to use the exact URL for each platform binary of the node 20.12.12. Here is an example

flake.nix Outdated Show resolved Hide resolved
flake.nix Outdated Show resolved Hide resolved
flake.nix Outdated Show resolved Hide resolved
Add nix related artifacts such that we can create a development
environment for nixos uses
@kayvank kayvank requested a review from eigen-vi October 12, 2024 01:36
rust-toolchain.toml Outdated Show resolved Hide resolved
flake.nix Outdated
Comment on lines 62 to 65
export ETH_RPC_URL='127.0.0.1:8545'
export ETHERSCAN_API_KEY='fake-key'
export HOLESKY_PRIVATE_KEY='fake-key'
export PRIVATE_KEY=0xac0974bec39a17e36ba4a6b4d238ff944bacb478cbed5efcae784d7bf4f2ff80

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could these be removed? we're likely going to have a more sophisticated setup for env vars later, and this will cause surprises

Copy link
Contributor Author

@kayvank kayvank Oct 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that a better solution is required here @eigen-vi and I would like to work on that next.
The rust code has a few dependencies on environment variables.
I can remove them. However, the rust code is dependent on these environment variables.

flake.nix Outdated Show resolved Hide resolved
simplify rust toolchain
Simplify environment variables in flake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants