Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non blocking da v2: frame publisher wrapper #6

Conversation

samlaf
Copy link
Collaborator

@samlaf samlaf commented Aug 23, 2024

wip exploration of the idea described in celo-org#213 (comment)
where I renamed DaPublisher to FramePublisher.

So far I'm not super convinced by this approach:

  • I don't like the fact that FramePublisher wraps the txmgr, because it couples altda with ethda code, and will make understanding the logic harder for people who don't care about altda
  • the fact that frames are put back in channels when eth txs fails (not sure why its done this way) makes this abstraction not encapsulating at all, since we still need to pass a channelManager to the FramePublisher

@samlaf samlaf marked this pull request as draft August 23, 2024 04:47
@samlaf samlaf changed the title Non blocking da implv2 frame publisher wrapper non blocking da v2: frame publisher wrapper Aug 23, 2024
@samlaf samlaf changed the base branch from devnet-monitoring to altda-devnet-monitoring August 28, 2024 05:09
@samlaf
Copy link
Collaborator Author

samlaf commented Aug 30, 2024

Closing as no longer needed. #7 is the approach we are going for.

@samlaf samlaf closed this Aug 30, 2024
@samlaf samlaf deleted the non-blocking-da-implv2-frame-publisher-wrapper branch September 12, 2024 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant