op-batcher refactor: non blocking event loop #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See https://hackmd.io/@samlaf/op-batcher-concurrent-altda-requests-design-doc for some background regarding this PR. Got the idea for this refactor from the Advanced Go Concurrency Patterns talk.
This is still a wip: wrote the initial refactor but I'm sure there's still bugs and blocking calls left. Want to get a sense of whether people like this or not before I invest more time in this non-trivial refactor.
Tests
tested by running the TestBatcherMultiTx test
and also manually by running the devnet with different configurations and sending some large txs.