EmptyLauncher supported cuda_visible_devices by memory left order #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wzh1994
reviewed
Oct 14, 2024
lazyllm/launcher.py
Outdated
| gpus = self.launcher._get_idle_gpus() | ||
| if gpus: | ||
| if self.launcher.ngpus in (None, 0): | ||
| empty_cmd = f'export CUDA_VISIBLE_DEVICES={gpus[0]} && ' |
wzh1994
reviewed
Oct 15, 2024
| @@ -173,6 +174,23 @@ class Job(Job): | |||
| def __init__(self, cmd, launcher, *, sync=True): | |||
| super(__class__, self).__init__(cmd, launcher, sync=sync) | |||
|
|
|||
| def _wrap_cmd(self, cmd): | |||
| gpus = self.launcher._get_idle_gpus() | |||
There was a problem hiding this comment.
可以先判断 self.launcher.ngpus，如果为0，则直接跳过，否则再_get_idle_gpus
lazyllm/launcher.py
Outdated
| gpus = self.launcher._get_idle_gpus() | ||
| if gpus and lazyllm.config['cuda_visible']: | ||
| if self.launcher.ngpus in (None, 0): | ||
| empty_cmd = f'CUDA_VISIBLE_DEVICES={gpus[0]} && ' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EmptyLauncher supports setting
CUDA_VISIBLE_DEVICESbased on the remaining GPU memory for each GPU.