Support edit metadata #414
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wzh1994
reviewed
Jan 15, 2025
| meta_dict = json.loads(doc.meta) if doc.meta else {} | ||
| for k, v in kv_pair.items(): | ||
| if k not in meta_dict: | ||
| meta_dict[k] = v |
There was a problem hiding this comment.
此处不合理，假设我有两个标签a和b先后add，第一次add的时候会赋值成a，然后第二次add时就报错了
There was a problem hiding this comment.
我建议metadata加的时候要简单指定一下是不是list（取一个适合业务的名字，比如vector_values=True）
There was a problem hiding this comment.
出于简化设计和易于使用的考量。改为了这样的设计：
前提约束：metadata 内容是扁平的，即 {key: val} val 中不会出现嵌套的dict。
增加metadata时， kv_pair类型约束为: Dict[str, Union[bool, int, float, str, list]]
- 若k为新增：使用v直接赋值
- k已存在，若meta[k] 为list：将v中元素追加至meta[k]中
- k已存在，meta[k] 非list：将meta[k]变为list，并追加v中所有元素
| @app.post("/delete_metadata_keys") | ||
| def delete_metadata_keys(self, del_metadata_request: DeleteMetadataRequest): | ||
| doc_ids = del_metadata_request.doc_ids | ||
| keys = del_metadata_request.keys |
There was a problem hiding this comment.
如果我想meta_dict[k].remove(v)，该怎么办
There was a problem hiding this comment.
已更新delete_metadata_item 接口，解决此需求
wzh1994
reviewed
Jan 20, 2025
lazyllm/tools/rag/doc_manager.py
Outdated
| keys: Optional[List[str]] = Field(None) | ||
| doc_ids: List[str] | ||
| # value type should be None/list/str | ||
| kv_pair: Optional[Dict[str, Union[None, bool, int, float, str, list]]] = Field(None) |
There was a problem hiding this comment.
也同时保留原来keys的逻辑吧，并且判断一下keys和kv_pair有且只能有一个
There was a problem hiding this comment.
这里稍微做了一下调整。 添加了keys 关键字，并且keys和kv_pair 可以 都存在/都不存在/存在一个。
功能效果如下：
- 都不存在，把所有用户设置的metadata key删除
- 只存在 keys，以key删除
- 只存在kv_pair, 以key+value 删除
- keys与kv_pair都存在。合并删除，即满足条件的key和kv_pair都会删除
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.