+ perfs improvements

Lcfvs · Jul 1, 2021 · 507c545 · 507c545
1 parent da2e6b2
commit 507c545
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 6 deletions.
diff --git a/lib/dom.js b/lib/dom.js
@@ -38,7 +38,7 @@ const tokenize = node => {
       for (const { name, value } of current.attributes) {
         const tokens = identify(value)
 
-        if (tokens) {
+        if (tokens.length) {
           attributes.set(name, tokens)
         }
       }
@@ -141,9 +141,15 @@ const fill = template => {
 }
 
 const value = (tokens, node, name, template) => {
+  const { length } = tokens
+
+  if (!length) {
+    return
+  }
+
   let value = node.getAttribute(name)
 
-  if (tokens.length === 1) {
+  if (length === 1) {
     const [{ key, optional }] = tokens
 
     value = resolve(key, optional, template)
@@ -179,7 +185,7 @@ const content = (tokens, node, template) => {
     const value = resolve(key, optional, template)
     const replacements = Array.isArray(value)
       ? value
-      : value && value[Symbol.iterator]
+      : value && typeof value === 'object' && value[Symbol.iterator]
         ? [...new Map(value).values()]
         : [value]
 

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@lcf.vs/dom-engine",
-  "version": "4.0.0",
+  "version": "4.0.1",
   "description": "A composable DOM based template engine",
   "type": "module",
   "scripts": {