Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Bevy 0.13 #35

Merged
merged 3 commits into from
Mar 1, 2024
Merged

Conversation

snendev
Copy link
Contributor

@snendev snendev commented Mar 1, 2024

Changes

  • Updates bevy dependencies from 0.12 to 0.12
  • Adds smol_str dev dependency in order to provide accurate logical keys in test structs. do we need to test this new property in any way?

@alice-i-cecile
Copy link
Contributor

I would prefer to have some tests for LogicalKey, but I won't block on it here.

@snendev
Copy link
Contributor Author

snendev commented Mar 1, 2024

I don't mind implementing in this PR. But I'm not sure what those tests should look like; maybe reading from ReceivedCharacters during playback? (Should that work as-is?)

@alice-i-cecile
Copy link
Contributor

I think that should work. But yeah, let's do it separately :)

@alice-i-cecile alice-i-cecile merged commit d4960c8 into Leafwing-Studios:main Mar 1, 2024
4 checks passed
@snendev
Copy link
Contributor Author

snendev commented Mar 1, 2024

ack -- looks like I checked in a random git file I didn't realize was there from when I was trying to cargo fmt 🤦🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants