Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add T3 instances #292

Closed
wants to merge 1 commit into from
Closed

Add T3 instances #292

wants to merge 1 commit into from

Conversation

JoostSaanen
Copy link

This is a failry easy PR, but add support for the new T3 instances.
AFAIK there is only one file needed to change.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 80.843% when pulling ffb3899 on JoostSaanen:add-t3-instances into fff582b on cristim:master.

cristim
cristim requested changes Aug 31, 2018
View reviewed changes
Copy link
Member

@cristim cristim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just saw the change is in a vendored dependency, so it will be overridden next time we update the dependencies.

This change really belongs to our upstream dependencies.

@cristim cristim closed this Aug 31, 2018
@cristim
Copy link
Member

cristim commented Sep 7, 2018

@JoostSaanen I tried to implement this in #295, please give it a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristim cristim cristim requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoostSaanen @coveralls @cristim