Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CodeQL analysis #31

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

CodeQL analysis #31

wants to merge 1 commit into from

Conversation

jibeee
Copy link

@jibeee jibeee commented Jul 1, 2022

No description provided.

@sonarcloud
Copy link

sonarcloud bot commented Jul 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jibeee jibeee marked this pull request as ready for review October 7, 2022 13:57
@sonarcloud
Copy link

sonarcloud bot commented Oct 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jibeee
Copy link
Author

jibeee commented Oct 7, 2022

Checks do not pass as CodeQL found defects. PR can be merged, defects can be solved after merge.

lpascal-ledger
lpascal-ledger reviewed Oct 7, 2022
View reviewed changes
.github/workflows/codeql-analysis.yml
branches: [ "master", "develop" ]
pull_request:
# The branches below must be a subset of the branches above
branches: [ "master", "develop" ]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like CodeQL could run on any PR, not only master or develop-backed ones.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR are made more or less exclusively on these branches, but as you prefer.

Also, see the comment: "The branches below must be a subset of the branches above".

Feel free to modify this behavior, I don't have a strong opinion on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpascal-ledger lpascal-ledger lpascal-ledger left review comments

@fbeutin-ledger fbeutin-ledger Awaiting requested review from fbeutin-ledger

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jibeee @lpascal-ledger