forked from solana-labs/ledger-app-solana
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extended signing support for Off-chain message signing #78
Open
0xMMBD
wants to merge
12
commits into
LedgerHQ:develop
Choose a base branch
from
blockydevs:pr/ocms-bd
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* request heap frame * set compute unit price * request units * set compute unit limit Added unit tests
updated links in readme file
Added message parsing Sign-in with solana (SIWS) Modified general item screens to fix memory issues on nanos Added unit tests & python tests for signing off-chain messages Includes changes for ComputeBudget instruction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added message parsing Sign-in with solana (SIWS) [https://github.com/phantom/sign-in-with-solana]
Off-chain message signing implemented according to: https://docs.solana.com/proposals/off-chain-message-signing
Modified general item screens to fix memory issues on nanos Added unit tests & python tests for signing off-chain
Empty application domain will be displayed as "Domain not provided" instead of base58 representation
Messages Includes changes for ComputeBudget instruction
Conditional compilation to change constant values in relation to used SDK