Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add whitelisted SPL tokens to show proper tickers #80

Merged
merged 8 commits into from
Aug 14, 2024

Conversation

sponomarev
Copy link

@sponomarev sponomarev commented Dec 5, 2023

Checklist

  • App update process has been followed
  • Target branch is develop
  • Application version has been bumped

CI status note:

@sponomarev sponomarev changed the title [WIP] Add whitelisted SPL tokens to show proper tickers Add whitelisted SPL tokens to show proper tickers Dec 8, 2023
@sponomarev sponomarev marked this pull request as ready for review December 8, 2023 13:38
@t-nelson
Copy link

t-nelson commented Dec 8, 2023

this is going to need to be device gated on the S. won't fit afaik

@sponomarev
Copy link
Author

this is going to need to be device gated on the S. won't fit afaik

@t-nelson Will you be able to explain what do you mean? Any changes needed?

@sponomarev sponomarev force-pushed the feat/add-spl-tickers branch 2 times, most recently from 6b7671a to 12aa68b Compare December 15, 2023 08:01
@jnwng
Copy link

jnwng commented Dec 21, 2023

this is going to need to be device gated on the S. won't fit afaik

@t-nelson Will you be able to explain what do you mean? Any changes needed?

there may not be enough memory on device to store the mapping of addresses to symbols. did you already test this on the emulator?

@sponomarev
Copy link
Author

there may not be enough memory on device to store the mapping of addresses to symbols. did you already test this on the emulator?

@jnwng Yep! We did! In addition to end-to-end tests with Ragger, manual QA was performed on the real Nano S device and Speculos as well. To check that everything works well, I've been asked to make sure that BTC/ETH + Solana + Exchange apps fit Nano S devices. Everything is smooth.

$ python3 -m ledgerblue.listApps --targetId 0x31100004

[{'flags': 1952336, 'hash_code_data': b'T\xf4\xff\x8f4Bw\x1c2\x9d\xcbp/z/\x84\xe9\xffx\x18|\x0f\xaaI~\xa9E\xe4o\xe3P\xc4', 'hash': b"\x1c`'\x1a\x9dL\xc3I\x816\x00\xfc\x1d\x86\xce\x01h\x19*\xb29\xb0\xb9\xda\xfd\x0c\xb2\x99\xdc\x1bB\xcf", 'name': 'Bitcoin'},
{'flags': 901712, 'hash_code_data': b'\x8f\xc9\xac8\xc0\x1fo\xea\xf3@\xb7\xe3 \x18\x8e\xbf\x01W5\xde\xea\xf5\xbd\xe2\xef\x131G\xdb\x0e8\x0e', 'hash': b'S\x85GG\x1ey\xf4`OGk\x10a\x94\xdd!2\x1a\x1b\xce\x81\x11\xd3U@_\x19\xd6B"S\x1e', 'name': 'Exchange'}]
[{'flags': 1345536, 'hash_code_data': b'|H\x8c\xabg\x02\xca\xd5\xdd\x95\x8al\xca\x81J\xe1\xb7\x838\x0f\xa4)Z\xfb\xe2g\xd1r\xd1\x01\xf3K', 'hash': b'\xc6o\x9fj\xd97r\xbb\xc7\xfdB\xe9\xe2\x9e\xdd\xc03\x88\xc5\xa1`\x08\xb3\x0e\x10\x83\xc2;z\xd2\xa2\xff', 'name': 'Solana'}]

@fbeutin-ledger
Copy link

CI is failing on functional tests for Flex and Stax during snapshots check
This is due to the Stax and Flex SDKs fonts and layouts having been updated since the test was last ran
Since the tests are OK on Nano devices it's not blocking
Info : Tests snapshots can be regenerated with --golden_run option

@fbeutin-ledger fbeutin-ledger merged commit 4d88a45 into LedgerHQ:develop Aug 14, 2024
130 of 133 checks passed
@sponomarev
Copy link
Author

@fbeutin-ledger @vforgeoux-ledger Functional tests snapshots for Flex and Stax has been updated in #92

@sponomarev sponomarev deleted the feat/add-spl-tickers branch August 16, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants