-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add whitelisted SPL tokens to show proper tickers #80
Add whitelisted SPL tokens to show proper tickers #80
Conversation
83c84a9
to
c160ed1
Compare
this is going to need to be device gated on the S. won't fit afaik |
@t-nelson Will you be able to explain what do you mean? Any changes needed? |
6b7671a
to
12aa68b
Compare
there may not be enough memory on device to store the mapping of addresses to symbols. did you already test this on the emulator? |
@jnwng Yep! We did! In addition to end-to-end tests with Ragger, manual QA was performed on the real Nano S device and Speculos as well. To check that everything works well, I've been asked to make sure that BTC/ETH + Solana + Exchange apps fit Nano S devices. Everything is smooth.
|
12aa68b
to
89701f2
Compare
89701f2
to
f27e77d
Compare
f27e77d
to
37f9a14
Compare
37f9a14
to
acab6d6
Compare
f1c2deb
to
f6cfefc
Compare
f6cfefc
to
00138c7
Compare
CI is failing on functional tests for Flex and Stax during snapshots check |
@fbeutin-ledger @vforgeoux-ledger Functional tests snapshots for Flex and Stax has been updated in #92 |
Checklist
develop
CI status note:
Sonarcloud / sonarcloud (pull_request) misconfiguration on the CI side?.
Project not found. Please check the 'sonar.projectKey' and 'sonar.organization' properties, the 'SONAR_TOKEN' environment variable, or contact the project administrator
Code style check / Check misspellings (pull_request) Typo in unrelated code that also present in the upsteam branch. Not sure why it wasn't triggered there
app-solana/src/ui/menu_nbgl.c
Line 87 in 5138865
app-solana/src/ui/menu_nbgl.c
Line 94 in 5138865
app-solana/src/ui/menu_nbgl.c
Line 101 in 5138865
Compilation & tests / Run ragger tests using the reusable workflow / Same failure present on the latest
develop
branch.